Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2525343004: Version 5.7.56.2 (cherry-pick) (Closed)

Created:
4 years ago by Michael Hablich
Modified:
4 years ago
Reviewers:
machenbach
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, Paweł Hajdan Jr., ulan
Target Ref:
refs/pending/heads/5.7.56
Project:
v8
Visibility:
Public.

Description

Version 5.7.56.2 (cherry-pick) Merged 29ee62443d87f8cdcf0157715f5205ab45d99c94 Revert of [base] Pass scalar arguments by value in CHECK/DCHECK (patchset #3 id:40001 of https://codereview.chromium.org/2524093002/ ) TBR=machenbach@chomium.org Committed: https://chromium.googlesource.com/v8/v8/+/b9b96e5448492323c4d5ebe7ddb714ef0f1e1c32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -48 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/base/logging.h View 4 chunks +21 lines, -29 lines 0 comments Download
M src/base/logging.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M test/unittests/base/logging-unittest.cc View 1 chunk +4 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Michael Hablich
4 years ago (2016-11-24 23:10:52 UTC) #1
Michael Hablich
4 years ago (2016-11-24 23:11:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b9b96e5448492323c4d5ebe7ddb714ef0f1e1c32 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698