[mjsunit] Change assertThrows such that it can check the exception message.

[mjsunit] Change assertThrows such that it can check the exception message.

Up until now assertThrows allows to check the type field of an
exception, which is, however, a custom field introduced in a single
regression test. With the change assertThrows allows to check the
message field of an exception, which is set for standard V8 exceptions
by default.

I use the new assertThrows to refactor test/mjsunit/wasm/divrem-trap.js

R=titzer@chromium.org

Committed: https://crrev.com/5d5ccb6e45e58d6a03397fe78b8fd4c43351c43e
Cr-Commit-Position: refs/heads/master@{#41302}

[ahaas, 2016-11-24 15:33:40]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 15:33:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-11-24 15:37:02]

https://codereview.chromium.org/2525313003/diff/1/test/mjsunit/mjsunit.js
File test/mjsunit/mjsunit.js (right):

https://codereview.chromium.org/2525313003/diff/1/test/mjsunit/mjsunit.js#new...
test/mjsunit/mjsunit.js:379: assertEquals(e.message, cause_opt);
What about checking both the type and the cause here?

https://codereview.chromium.org/2525313003/diff/1/test/mjsunit/wasm/divrem-tr...
File test/mjsunit/wasm/divrem-trap.js (right):

https://codereview.chromium.org/2525313003/diff/1/test/mjsunit/wasm/divrem-tr...
test/mjsunit/wasm/divrem-trap.js:33: assertThrows(() => divs(100, 0),
WebAssembly.RuntimeError,
I think we can still keep the helper function, but make it use the mjsunit
version internally, no?

[commit-bot: I haz the power, 2016-11-24 16:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 16:08:58]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-11-28 09:47:53]

https://codereview.chromium.org/2525313003/diff/1/test/mjsunit/mjsunit.js
File test/mjsunit/mjsunit.js (right):

https://codereview.chromium.org/2525313003/diff/1/test/mjsunit/mjsunit.js#new...
test/mjsunit/mjsunit.js:379: assertEquals(e.message, cause_opt);
On 2016/11/24 at 15:37:01, titzer wrote:
> What about checking both the type and the cause here?

The JS standard defines only message, not type. I guess the check of e.type was
only introduced for the one regression test. I think it would make tests less
readable to check both type and message.

https://codereview.chromium.org/2525313003/diff/1/test/mjsunit/wasm/divrem-tr...
File test/mjsunit/wasm/divrem-trap.js (right):

https://codereview.chromium.org/2525313003/diff/1/test/mjsunit/wasm/divrem-tr...
test/mjsunit/wasm/divrem-trap.js:33: assertThrows(() => divs(100, 0),
WebAssembly.RuntimeError,
On 2016/11/24 at 15:37:02, titzer wrote:
> I think we can still keep the helper function, but make it use the mjsunit
version internally, no?

Done.

[ahaas, 2016-11-28 09:48:54]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 09:48:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-11-28 09:51:32]

On 2016/11/28 09:47:53, ahaas wrote:
> https://codereview.chromium.org/2525313003/diff/1/test/mjsunit/mjsunit.js
> File test/mjsunit/mjsunit.js (right):
> 
>
https://codereview.chromium.org/2525313003/diff/1/test/mjsunit/mjsunit.js#new...
> test/mjsunit/mjsunit.js:379: assertEquals(e.message, cause_opt);
> On 2016/11/24 at 15:37:01, titzer wrote:
> > What about checking both the type and the cause here?
> 
> The JS standard defines only message, not type. I guess the check of e.type
was
> only introduced for the one regression test. I think it would make tests less
> readable to check both type and message.
> 
>
https://codereview.chromium.org/2525313003/diff/1/test/mjsunit/wasm/divrem-tr...
> File test/mjsunit/wasm/divrem-trap.js (right):
> 
>
https://codereview.chromium.org/2525313003/diff/1/test/mjsunit/wasm/divrem-tr...
> test/mjsunit/wasm/divrem-trap.js:33: assertThrows(() => divs(100, 0),
> WebAssembly.RuntimeError,
> On 2016/11/24 at 15:37:02, titzer wrote:
> > I think we can still keep the helper function, but make it use the mjsunit
> version internally, no?
> 
> Done.

lgtm

[commit-bot: I haz the power, 2016-11-28 10:15:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 10:15:25]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-11-28 10:24:47]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-11-28 10:24:51]

The CQ bit was unchecked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-11-28 10:24:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 10:26:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480328687229080,
"parent_rev": "fee69375d469e75bb03b126bd3071de9546ef140", "commit_rev":
"0cd93c9d3033b2e392ac696a3069cdba044fc96f"}

[commit-bot: I haz the power, 2016-11-28 10:26:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-28 10:26:48]

Description was changed from

==========
[mjsunit] Change assertThrows such that it can check the exception message.

Up until now assertThrows allows to check the type field of an
exception, which is, however, a custom field introduced in a single
regression test. With the change assertThrows allows to check the
message field of an exception, which is set for standard V8 exceptions
by default.

I use the new assertThrows to refactor test/mjsunit/wasm/divrem-trap.js

R=titzer@chromium.org
==========

to

==========
[mjsunit] Change assertThrows such that it can check the exception message.

Up until now assertThrows allows to check the type field of an
exception, which is, however, a custom field introduced in a single
regression test. With the change assertThrows allows to check the
message field of an exception, which is set for standard V8 exceptions
by default.

I use the new assertThrows to refactor test/mjsunit/wasm/divrem-trap.js

R=titzer@chromium.org

Committed: https://crrev.com/5d5ccb6e45e58d6a03397fe78b8fd4c43351c43e
Cr-Commit-Position: refs/heads/master@{#41302}
==========

[commit-bot: I haz the power, 2016-11-28 10:26:49]

Patchset 2 (id:??) landed as
https://crrev.com/5d5ccb6e45e58d6a03397fe78b8fd4c43351c43e
Cr-Commit-Position: refs/heads/master@{#41302}