chrome/browser/subresource_filter/chrome_subresource_filter_client.cc - Issue 2525303002: Don't duplicate the Subresource Filter prompt after it was shown already.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/subresource_filter/chrome_subresource_filter_client.cc

Issue 2525303002: Don't duplicate the Subresource Filter prompt after it was shown already. (Closed)

Patch Set: . Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/subresource_filter/chrome_subresource_filter_client.h ('k') | chrome/browser/subresource_filter/subresource_filter_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/subresource_filter/chrome_subresource_filter_client.cc

diff --git a/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc b/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc

index c87590891313947d51eb1368f402d52c66dadd6a..e79a23c8d49abda265360c84dd382f374c10e23c 100644

--- a/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc

+++ b/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc

@@ -11,7 +11,7 @@

ChromeSubresourceFilterClient::ChromeSubresourceFilterClient(

content::WebContents* web_contents)

- : web_contents_(web_contents) {

+ : web_contents_(web_contents), shown_for_navigation_(false) {

DCHECK(web_contents);

}

@@ -19,6 +19,9 @@ ChromeSubresourceFilterClient::~ChromeSubresourceFilterClient() {}

void ChromeSubresourceFilterClient::ToggleNotificationVisibility(

bool visibility) {

+ if (shown_for_navigation_ && visibility)

+ return;

+ shown_for_navigation_ = visibility;

UMA_HISTOGRAM_BOOLEAN("SubresourceFilter.Prompt.NumVisibility", visibility);

TabSpecificContentSettings* content_settings =

TabSpecificContentSettings::FromWebContents(web_contents_);