Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2525253002: Revert of [stubs] Fix AccessorInfo mixup in KeyedStoreGeneric (Closed)

Created:
4 years ago by Michael Hablich
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [stubs] Fix AccessorInfo mixup in KeyedStoreGeneric (patchset #1 id:1 of https://codereview.chromium.org/2525913002/ ) Reason for revert: Needed to revert 2661b3e8a5447773a23a219ba085454c459b654b Original issue's description: > [stubs] Fix AccessorInfo mixup in KeyedStoreGeneric > > BUG=chromium:668101 > > Committed: https://crrev.com/2661b3e8a5447773a23a219ba085454c459b654b > Cr-Commit-Position: refs/heads/master@{#41223} TBR=ishell@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:668101 Committed: https://crrev.com/e461facff2a5e349269f33b1619473ab01ae18eb Cr-Commit-Position: refs/heads/master@{#41250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
M src/code-stub-assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/keyed-store-generic.cc View 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/regress/regress-crbug-668101.js View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Hablich
Created Revert of [stubs] Fix AccessorInfo mixup in KeyedStoreGeneric
4 years ago (2016-11-24 08:40:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525253002/1
4 years ago (2016-11-24 08:40:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 08:41:22 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e461facff2a5e349269f33b1619473ab01ae18eb Cr-Commit-Position: refs/heads/master@{#41250}
4 years ago (2016-11-24 08:41:39 UTC) #7
Jakob Kummerow
4 years ago (2016-11-24 14:58:35 UTC) #8
Message was sent while issue was closed.
Will reland as part of https://codereview.chromium.org/2528883003/.

Powered by Google App Engine
This is Rietveld 408576698