[fullcodegen] Remove deprecated support for super calls.

[fullcodegen] Remove deprecated support for super constructor calls.

All super constructor calls go through the ignition + turbofan pipeline, so this is dead code.

BUG=v8:5657
Committed: https://crrev.com/0a1dcadd0529c4fe51ff913d4376807cb9de8328
Cr-Commit-Position: refs/heads/master@{#41313}

[petermarshall, 2016-11-24 09:25:00]

Description was changed from

==========
[fullcodegen] Remove deprecated support for super calls.

All super calls go through the ingition + turbofan pipelines, so this is dead
code.

BUG=v8:5657
==========

to

==========
[fullcodegen] Remove deprecated support for super constructor calls.

All super constructor calls go through the ingition + turbofan pipelines, so
this
is dead code.

BUG=v8:5657
==========

[petermarshall, 2016-11-24 09:25:15]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 09:25:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 09:52:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 09:52:12]

Dry run: This issue passed the CQ dry run.

[petermarshall, 2016-11-24 10:00:15]

petermarshall@chromium.org changed reviewers:
+ bmeurer@chromium.org, rmcilroy@chromium.org

[petermarshall, 2016-11-24 10:00:15]

PTAL :)

[Benedikt Meurer, 2016-11-24 10:03:31]

bmeurer@chromium.org changed required reviewers:
+ rmcilroy@chromium.org

[Benedikt Meurer, 2016-11-24 10:03:32]

Very nice, LGTM. Probably needs to wait for a "good to go" from Ross
(clusterfuzz discovered some problems with the switch to Ignition only).

[rmcilroy, 2016-11-24 18:13:05]

Could you also remove the relevant code from ASTGraphBuilder which should also
never see this any longer. Also fix typo in description (Ignition).

I've landed a fix for the clusterfuzz issue, so we should be good to go once
these comments are addressed.

https://codereview.chromium.org/2525233003/diff/1/src/full-codegen/full-codeg...
File src/full-codegen/full-codegen.cc (right):

https://codereview.chromium.org/2525233003/diff/1/src/full-codegen/full-codeg...
src/full-codegen/full-codegen.cc:1705: UNREACHABLE();
nit - could you move this to the bottom of the switch and merge with
Call::WITH_CALL after https://codereview.chromium.org/2514393002/ lands.

[petermarshall, 2016-11-24 18:55:15]

Description was changed from

==========
[fullcodegen] Remove deprecated support for super constructor calls.

All super constructor calls go through the ingition + turbofan pipelines, so
this
is dead code.

BUG=v8:5657
==========

to

==========
[fullcodegen] Remove deprecated support for super constructor calls.

All super constructor calls go through the ignition + turbofan pipelines, so
this
is dead code.

BUG=v8:5657
==========

[petermarshall, 2016-11-28 09:12:13]

Description was changed from

==========
[fullcodegen] Remove deprecated support for super constructor calls.

All super constructor calls go through the ignition + turbofan pipelines, so
this
is dead code.

BUG=v8:5657
==========

to

==========
[fullcodegen] Remove deprecated support for super constructor calls.

All super constructor calls go through the ignition + turbofan pipeline, so this
is dead code.

BUG=v8:5657
==========

[petermarshall, 2016-11-28 09:14:48]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 09:14:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[petermarshall, 2016-11-28 09:18:11]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 09:18:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[petermarshall, 2016-11-28 09:18:50]

On 2016/11/24 at 18:13:05, rmcilroy wrote:
> Could you also remove the relevant code from ASTGraphBuilder which should also
never see this any longer. Also fix typo in description (Ignition).
Done!
> 
> I've landed a fix for the clusterfuzz issue, so we should be good to go once
these comments are addressed.
> 
>
https://codereview.chromium.org/2525233003/diff/1/src/full-codegen/full-codeg...
> File src/full-codegen/full-codegen.cc (right):
> 
>
https://codereview.chromium.org/2525233003/diff/1/src/full-codegen/full-codeg...
> src/full-codegen/full-codegen.cc:1705: UNREACHABLE();
> nit - could you move this to the bottom of the switch and merge with
Call::WITH_CALL after https://codereview.chromium.org/2514393002/ lands.

[petermarshall, 2016-11-28 09:19:27]

PTAL for ast-graph-builder.cc :)

https://codereview.chromium.org/2525233003/diff/1/src/full-codegen/full-codeg...
File src/full-codegen/full-codegen.cc (right):

https://codereview.chromium.org/2525233003/diff/1/src/full-codegen/full-codeg...
src/full-codegen/full-codegen.cc:1705: UNREACHABLE();
On 2016/11/24 at 18:13:04, rmcilroy wrote:
> nit - could you move this to the bottom of the switch and merge with
Call::WITH_CALL after https://codereview.chromium.org/2514393002/ lands.

Done

[Benedikt Meurer, 2016-11-28 09:19:58]

LGTM! Thanks!

[commit-bot: I haz the power, 2016-11-28 09:44:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 09:44:18]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-11-28 12:21:29]

LGTM, thanks!

[petermarshall, 2016-11-28 12:22:19]

The CQ bit was checked by petermarshall@chromium.org

[commit-bot: I haz the power, 2016-11-28 12:22:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 12:23:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480335739051560,
"parent_rev": "a011c827b3115f11438255f0301737b15a893cdb", "commit_rev":
"b242dda5db18dbf024d8a6658ab259058a29c57a"}

[commit-bot: I haz the power, 2016-11-28 12:24:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-28 12:24:15]

Description was changed from

==========
[fullcodegen] Remove deprecated support for super constructor calls.

All super constructor calls go through the ignition + turbofan pipeline, so this
is dead code.

BUG=v8:5657
==========

to

==========
[fullcodegen] Remove deprecated support for super constructor calls.

All super constructor calls go through the ignition + turbofan pipeline, so this
is dead code.

BUG=v8:5657

Committed: https://crrev.com/0a1dcadd0529c4fe51ff913d4376807cb9de8328
Cr-Commit-Position: refs/heads/master@{#41313}
==========

[commit-bot: I haz the power, 2016-11-28 12:24:16]

Patchset 3 (id:??) landed as
https://crrev.com/0a1dcadd0529c4fe51ff913d4376807cb9de8328
Cr-Commit-Position: refs/heads/master@{#41313}