Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: third_party/WebKit/Source/core/svg/SVGPathElement.h

Issue 2525233002: Move pathLength attribute from SVGPathElement to SVGGeometryElement. (Closed)
Patch Set: Align with review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGPathElement.h
diff --git a/third_party/WebKit/Source/core/svg/SVGPathElement.h b/third_party/WebKit/Source/core/svg/SVGPathElement.h
index cd33a84a20428abf104b9d052868d83e695400b0..b56d61c7f9d3bb3bff0c9fda7d206d10347775e1 100644
--- a/third_party/WebKit/Source/core/svg/SVGPathElement.h
+++ b/third_party/WebKit/Source/core/svg/SVGPathElement.h
@@ -22,7 +22,6 @@
#define SVGPathElement_h
#include "core/SVGNames.h"
-#include "core/svg/SVGAnimatedNumber.h"
#include "core/svg/SVGAnimatedPath.h"
#include "core/svg/SVGGeometryElement.h"
#include "platform/heap/Handle.h"
@@ -45,8 +44,7 @@ class SVGPathElement final : public SVGGeometryElement {
unsigned getPathSegAtLength(float distance);
SVGAnimatedPath* path() const { return m_path.get(); }
- SVGAnimatedNumber* pathLength() const { return m_pathLength.get(); }
- float pathLengthScaleFactor() const;
+ float computePathLength() const override;
const SVGPathByteStream& pathByteStream() const {
return stylePath()->byteStream();
}
@@ -71,7 +69,6 @@ class SVGPathElement final : public SVGGeometryElement {
void invalidateMPathDependencies();
- Member<SVGAnimatedNumber> m_pathLength;
Member<SVGAnimatedPath> m_path;
};
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGGeometryElement.idl ('k') | third_party/WebKit/Source/core/svg/SVGPathElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698