third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp - Issue 2525233002: Move pathLength attribute from SVGPathElement to SVGGeometryElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp

Issue 2525233002: Move pathLength attribute from SVGPathElement to SVGGeometryElement. (Closed)

Patch Set: Align with review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp

index 932e938c00b5740d9a0ab948c03843e6116b8d2b..0c253d7315b336381d32759e2b740a6dfc8a95d1 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp

@@ -79,10 +79,9 @@ void LayoutSVGShape::createPath() {

}

float LayoutSVGShape::dashScaleFactor() const {

- if (!isSVGPathElement(element()) ||

- !styleRef().svgStyle().strokeDashArray()->size())

+ if (!styleRef().svgStyle().strokeDashArray()->size())

return 1;

- return toSVGPathElement(*element()).pathLengthScaleFactor();

+ return toSVGGeometryElement(*element()).pathLengthScaleFactor();

}

void LayoutSVGShape::updateShapeFromElement() {