Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp

Issue 2525233002: Move pathLength attribute from SVGPathElement to SVGGeometryElement. (Closed)
Patch Set: Align with review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | third_party/WebKit/Source/core/svg/SVGGeometryElement.h » ('j') | third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
index 932e938c00b5740d9a0ab948c03843e6116b8d2b..11fa7c4b2787447d659454717675a4390157aa07 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
@@ -79,10 +79,10 @@ void LayoutSVGShape::createPath() {
}
float LayoutSVGShape::dashScaleFactor() const {
- if (!isSVGPathElement(element()) ||
+ if (!element()->isSVGGeometryElement() ||
fs 2016/11/28 10:29:42 This is expected to be false always (see construct
Shanmuga Pandi 2016/11/28 12:24:14 Done.
!styleRef().svgStyle().strokeDashArray()->size())
return 1;
- return toSVGPathElement(*element()).pathLengthScaleFactor();
+ return toSVGGeometryElement(*element()).pathLengthScaleFactor();
}
void LayoutSVGShape::updateShapeFromElement() {
« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | third_party/WebKit/Source/core/svg/SVGGeometryElement.h » ('j') | third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698