Move pathLength attribute from SVGPathElement to SVGGeometryElement.

third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp

 /*
  * Copyright (C) 2013 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 21 matching lines @@
 
 #include "core/SVGNames.h"
 #include "core/layout/HitTestRequest.h"
 #include "core/layout/PointerEventsHitRules.h"
 #include "core/layout/svg/LayoutSVGPath.h"
 #include "core/layout/svg/LayoutSVGShape.h"
 #include "core/svg/SVGPointTearOff.h"
 
 namespace blink {
 
+class SVGAnimatedPathLength final : public SVGAnimatedNumber {
+ public:
+  static SVGAnimatedPathLength* create(SVGGeometryElement* contextElement) {
+    return new SVGAnimatedPathLength(contextElement);
+  }
+
+  SVGParsingError setBaseValueAsString(const String& value) override {
+    SVGParsingError parseStatus =
+        SVGAnimatedNumber::setBaseValueAsString(value);
+    if (parseStatus == SVGParseStatus::NoError && baseValue()->value() < 0)
+      parseStatus = SVGParseStatus::NegativeValue;
+    return parseStatus;
+  }
+
+ private:
+  explicit SVGAnimatedPathLength(SVGGeometryElement* contextElement)
+      : SVGAnimatedNumber(contextElement,
+                          SVGNames::pathLengthAttr,
+                          SVGNumber::create()) {}
+};
+
 SVGGeometryElement::SVGGeometryElement(const QualifiedName& tagName,
                                        Document& document,
                                        ConstructionType constructionType)
-    : SVGGraphicsElement(tagName, document, constructionType) {}
+    : SVGGraphicsElement(tagName, document, constructionType),
+      m_pathLength(SVGAnimatedPathLength::create(this)) {
+  addToPropertyMap(m_pathLength);
+}
+
+DEFINE_TRACE(SVGGeometryElement) {
+  visitor->trace(m_pathLength);
+  SVGGraphicsElement::trace(visitor);
+}
 
 bool SVGGeometryElement::isPointInFill(SVGPointTearOff* point) const {
   document().updateStyleAndLayoutIgnorePendingStylesheets();
 
   // FIXME: Eventually we should support isPointInFill for display:none
   // elements.
   if (!layoutObject() || !layoutObject()->isSVGShape())
     return false;
 
   HitTestRequest request(HitTestRequest::ReadOnly);
@@ skipping 42 matching lines @@
 SVGPointTearOff* SVGGeometryElement::getPointAtLength(float length) {
   document().updateStyleAndLayoutIgnorePendingStylesheets();
 
   FloatPoint point;
   if (layoutObject())
     point = asPath().pointAtLength(length);
   return SVGPointTearOff::create(SVGPoint::create(point), 0,
                                  PropertyIsNotAnimVal);
 }
 
+float SVGGeometryElement::pathLengthScaleFactor() const {
+  if (!pathLength()->isSpecified())
+    return 1;
+  float authorPathLength = pathLength()->currentValue()->value();
+  if (authorPathLength < 0)
+    return 1;
+  if (!authorPathLength)
+    return 0;
+  if (!layoutObject())

[fs, 2016/11/28 10:29:42]

I think you could DCHECK this instead. But I think the asPath() implementations
does that already, so this could as well be dropped.

[Shanmuga Pandi, 2016/11/28 12:24:14]

Done.

+    return 1;
+  float computedPathLength = asPath().length();

[fs, 2016/11/28 10:29:42]

Optionally, pathLengthScaleFactor could be non-virtual, and a new method
"compute(d)PathLength" be added instead. That would share more code (and avoid
virtual dispatch in the general case.)

[Shanmuga Pandi, 2016/11/28 12:24:14]

Done.

+  if (!computedPathLength)
+    return 1;
+  return computedPathLength / authorPathLength;
+}
+
 LayoutObject* SVGGeometryElement::createLayoutObject(const ComputedStyle&) {
   // By default, any subclass is expected to do path-based drawing.
   return new LayoutSVGPath(this);
 }
 
 }  // namespace blink