Add chrome_changes file

Add chrome_changes file

BUG=skia:2457
Committed: http://code.google.com/p/skia/source/detail?r=14415

[borenet, 2014-04-24 15:13:32]

Should the name of this file or the comment text be changed for clarity?

[bsalomon, 2014-04-24 15:17:30]

On 2014/04/24 15:13:32, borenet wrote:
> Should the name of this file or the comment text be changed for clarity?

should it be in the root dir? Otherwise, lgtm.

[borenet, 2014-04-24 15:24:11]

Adding more people for discussion.

[epoger, 2014-04-24 15:28:59]

lgtm

[scroggo, 2014-04-24 17:09:21]

On 2014/04/24 15:17:30, bsalomon wrote:
> On 2014/04/24 15:13:32, borenet wrote:
> > Should the name of this file or the comment text be changed for clarity?
> 
> should it be in the root dir? Otherwise, lgtm.

+1 to being somewhere other than root, although I don't have a better
suggestion. If we have more things that are only necessary for chrome merging,
maybe it should go there?

[borenet, 2014-04-24 19:45:24]

On 2014/04/24 17:09:21, scroggo wrote:
> On 2014/04/24 15:17:30, bsalomon wrote:
> > On 2014/04/24 15:13:32, borenet wrote:
> > > Should the name of this file or the comment text be changed for clarity?
> > 
> > should it be in the root dir? Otherwise, lgtm.
> 
> +1 to being somewhere other than root, although I don't have a better
> suggestion. If we have more things that are only necessary for chrome merging,
> maybe it should go there?

AFAICT there's not much chrome-specific stuff.  I'd suggest putting it into
tools/, but it's already pretty crowded with *_pictures, skimage, various
scripts, etc.

[bsalomon, 2014-04-24 20:57:17]

On 2014/04/24 19:45:24, borenet wrote:
> On 2014/04/24 17:09:21, scroggo wrote:
> > On 2014/04/24 15:17:30, bsalomon wrote:
> > > On 2014/04/24 15:13:32, borenet wrote:
> > > > Should the name of this file or the comment text be changed for clarity?
> > > 
> > > should it be in the root dir? Otherwise, lgtm.
> > 
> > +1 to being somewhere other than root, although I don't have a better
> > suggestion. If we have more things that are only necessary for chrome
merging,
> > maybe it should go there?
> 
> AFAICT there's not much chrome-specific stuff.  I'd suggest putting it into
> tools/, but it's already pretty crowded with *_pictures, skimage, various
> scripts, etc.

tools/chromium?

We could move compare_codereview.py there as well.

[borenet, 2014-04-28 15:21:54]

Ping. Any more opinions on this?  I'd like to avoid burying the file, so that
nobody forgets to make changes to it.

[borenet, 2014-04-28 15:22:28]

On 2014/04/28 15:21:54, borenet wrote:
> Ping. Any more opinions on this?  I'd like to avoid burying the file, so that
> nobody forgets to make changes to it.

(and maybe we can add a presubmit check so that if you change the API it reminds
you that you may need to change the file)

[scroggo, 2014-04-28 15:25:58]

On 2014/04/28 15:22:28, borenet wrote:
> On 2014/04/28 15:21:54, borenet wrote:
> > Ping. Any more opinions on this?  I'd like to avoid burying the file, so
that
> > nobody forgets to make changes to it.

I'd argue that the more things we add to root, everything in root is buried
anyway.
That said, root is not a terrible place to bury it, and if you like root, then
lgtm.

> 
> (and maybe we can add a presubmit check so that if you change the API it
reminds
> you that you may need to change the file)

+1

[borenet, 2014-04-28 16:38:02]

Okay, it seems like there aren't many strong opinions on this.  Patch set 2
moves the file into tools/chromium.  If there aren't any objections I'll go
ahead and commit.

[borenet, 2014-04-28 17:37:54]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2014-04-28 17:38:26]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/borenet@google.com/252523002/20001

[commit-bot: I haz the power, 2014-04-28 19:40:55]

Change committed as 14415