Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2525163002:
Add the exact versions to the vulcanize.md install command. (Closed)
DescriptionAdd the exact versions to the vulcanize.md install command.
BUG=629406
Committed: https://crrev.com/3674a562b4e1138094ac37e0d40b41ed56b16529
Cr-Commit-Position: refs/heads/master@{#434401}
Patch Set 1 #
Total comments: 2
Patch Set 2 : wrap #
Total comments: 2
Patch Set 3 : wrapagain #Messages
Total messages: 18 (8 generated)
calamity@chromium.org changed reviewers: + tsergeant@chromium.org
lgtm https://codereview.chromium.org/2525163002/diff/1/docs/vulcanize.md File docs/vulcanize.md (right): https://codereview.chromium.org/2525163002/diff/1/docs/vulcanize.md#newcode32 docs/vulcanize.md:32: $ npm install -g crisper@2.0.1 vulcanize@1.14.8 uglifyjs@2.4.10 polymer-css-build@0.0.6 Maybe this should be wrapped to a new line, if there's a way to do it which is still copy-pasteable?
https://codereview.chromium.org/2525163002/diff/1/docs/vulcanize.md File docs/vulcanize.md (right): https://codereview.chromium.org/2525163002/diff/1/docs/vulcanize.md#newcode32 docs/vulcanize.md:32: $ npm install -g crisper@2.0.1 vulcanize@1.14.8 uglifyjs@2.4.10 polymer-css-build@0.0.6 On 2016/11/24 02:26:37, tsergeant wrote: > Maybe this should be wrapped to a new line, if there's a way to do it which is > still copy-pasteable? Done. WDYT?
https://codereview.chromium.org/2525163002/diff/20001/docs/vulcanize.md File docs/vulcanize.md (right): https://codereview.chromium.org/2525163002/diff/20001/docs/vulcanize.md#newco... docs/vulcanize.md:32: uglifyjs@2.4.10 polymer-css-build@0.0.6 I don't recognize this syntax? The regular github-flavoured markdown way to do this would be ```bash $ npm install -g crisper@2.0.1 vulcanize@1.14.8 uglifyjs@2.4.10 \ polymer-css-build@0.0.6 ``` (see: https://gerrit.googlesource.com/gitiles/+/master/Documentation/markdown.md#Co...)
Patchset #3 (id:40001) has been deleted
https://codereview.chromium.org/2525163002/diff/20001/docs/vulcanize.md File docs/vulcanize.md (right): https://codereview.chromium.org/2525163002/diff/20001/docs/vulcanize.md#newco... docs/vulcanize.md:32: uglifyjs@2.4.10 polymer-css-build@0.0.6 On 2016/11/24 03:30:29, tsergeant wrote: > I don't recognize this syntax? The regular github-flavoured markdown way to do > this would be > > ```bash > $ npm install -g mailto:crisper@2.0.1 mailto:vulcanize@1.14.8 mailto:uglifyjs@2.4.10 \ > mailto:polymer-css-build@0.0.6 > ``` > > (see: > https://gerrit.googlesource.com/gitiles/+/master/Documentation/markdown.md#Co...) Done.
The CQ bit was checked by calamity@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tsergeant@chromium.org Link to the patchset: https://codereview.chromium.org/2525163002/#ps60001 (title: "wrapagain")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by tsergeant@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480026666564140,
"parent_rev": "c9621ddf25810b84cb993c773ed9b75602e60332", "commit_rev":
"eebdbe1e4c0382855ba8e24551204619421c41c2"}
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add the exact versions to the vulcanize.md install command. BUG=629406 ========== to ========== Add the exact versions to the vulcanize.md install command. BUG=629406 Committed: https://crrev.com/3674a562b4e1138094ac37e0d40b41ed56b16529 Cr-Commit-Position: refs/heads/master@{#434401} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/3674a562b4e1138094ac37e0d40b41ed56b16529 Cr-Commit-Position: refs/heads/master@{#434401} |
