chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc - Issue 252513004: Reland r265807: "Moves the notification icon out of th..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

Issue 252513004: Reland r265807: "Moves the notification icon out of th..." (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Disable tray size test on Vista since it won't have any effect on a new icon. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/message_center/web_notification_tray.cc ('k') | chrome/browser/ui/views/message_center/web_notification_tray_win.cc » ('j') | chrome/browser/ui/views/status_icons/status_tray_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

diff --git a/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc b/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

index 6e95b0b80a4fa455bdcbaa722f932cfc9fbd9291..1a1889c9f6b786ed734a06bad6edd09358190094 100644

--- a/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

+++ b/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

@@ -136,7 +136,7 @@ IN_PROC_BROWSER_TEST_F(WebNotificationTrayTest, WebNotifications) {

}

IN_PROC_BROWSER_TEST_F(WebNotificationTrayTest, WebNotificationPopupBubble) {

- scoped_ptr<WebNotificationTray> tray(new WebNotificationTray());

+ scoped_ptr<WebNotificationTray> tray(new WebNotificationTray(NULL));

tray->message_center();

// Adding a notification should show the popup bubble.

@@ -162,7 +162,7 @@ using message_center::NotificationList;

// Flaky, see http://crbug.com/222500 .

IN_PROC_BROWSER_TEST_F(WebNotificationTrayTest,

DISABLED_ManyMessageCenterNotifications) {

- scoped_ptr<WebNotificationTray> tray(new WebNotificationTray());

+ scoped_ptr<WebNotificationTray> tray(new WebNotificationTray(NULL));

message_center::MessageCenter* message_center = tray->message_center();

// Add the max visible notifications +1, ensure the correct visible number.

@@ -183,7 +183,7 @@ IN_PROC_BROWSER_TEST_F(WebNotificationTrayTest,

}

IN_PROC_BROWSER_TEST_F(WebNotificationTrayTest, ManyPopupNotifications) {

- scoped_ptr<WebNotificationTray> tray(new WebNotificationTray());

+ scoped_ptr<WebNotificationTray> tray(new WebNotificationTray(NULL));

message_center::MessageCenter* message_center = tray->message_center();

// Add the max visible popup notifications +1, ensure the correct num visible.