Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 252513002: Correcting and splitting up WebRTC metrics by unit. (Closed)

Created:
6 years, 8 months ago by phoglund_chromium
Modified:
6 years, 8 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

Correcting and splitting up WebRTC metrics by unit. The perf dashboard can only display one unit (e.g. ms, bit/s, etc) per graph, so this patch splits the metrics into reasonable buckets. I deliberately didn't name them like the old buckets in order to reduce confusion (e.g. audio_send, video_recv, and so on). Also it turns out I had mixed up video_recv and video_send, so this patch corrects that. Another benefit is that we won't see huge values (bytes_received) with small values (num_firs_recv), which makes the graphs easier to read. R=kjellander@chromium.org,xians@chromium.org BUG=357525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -74 lines) Patch
M chrome/browser/media/webrtc_browsertest_perf.cc View 3 chunks +93 lines, -74 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
phoglund_chromium
kjellander: main review xians: owner stamp
6 years, 8 months ago (2014-04-24 10:04:15 UTC) #1
no longer working on chromium
On 2014/04/24 10:04:15, phoglund wrote: > kjellander: main review > xians: owner stamp owner stamp ...
6 years, 8 months ago (2014-04-24 10:51:29 UTC) #2
kjellander_chromium
On 2014/04/24 10:51:29, xians1 wrote: > On 2014/04/24 10:04:15, phoglund wrote: > > kjellander: main ...
6 years, 8 months ago (2014-04-24 14:14:01 UTC) #3
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 8 months ago (2014-04-24 14:14:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/252513002/1
6 years, 8 months ago (2014-04-24 14:17:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 16:15:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-24 16:15:25 UTC) #7
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 8 months ago (2014-04-24 18:53:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/252513002/1
6 years, 8 months ago (2014-04-24 21:10:20 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 23:15:31 UTC) #10
Message was sent while issue was closed.
Change committed as 266031

Powered by Google App Engine
This is Rietveld 408576698