Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: runtime/vm/profiler.h

Issue 2525103003: Retry landing cl for issue with TSAN. (Closed)
Patch Set: Address code review comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/os_thread_macos.cc ('k') | runtime/vm/profiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler.h
diff --git a/runtime/vm/profiler.h b/runtime/vm/profiler.h
index 5b86c55c2f2ff666ee30227a57a2584628ee0de7..ee87a31d954051b61af6a7a822b7f2bb78da23eb 100644
--- a/runtime/vm/profiler.h
+++ b/runtime/vm/profiler.h
@@ -55,7 +55,7 @@ class Profiler : public AllStatic {
static SampleBuffer* sample_buffer() { return sample_buffer_; }
static void DumpStackTrace(void* context);
- static void DumpStackTrace(bool native_stack_trace = true);
+ static void DumpStackTrace();
static void SampleAllocation(Thread* thread, intptr_t cid);
@@ -75,10 +75,7 @@ class Profiler : public AllStatic {
}
private:
- static void DumpStackTrace(bool native_stack_trace,
- uword sp,
- uword fp,
- uword pc);
+ static void DumpStackTrace(uword sp, uword fp, uword pc);
// Does not walk the thread's stack.
static void SampleThreadSingleFrame(Thread* thread, uintptr_t pc);
« no previous file with comments | « runtime/vm/os_thread_macos.cc ('k') | runtime/vm/profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698