Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2525103003: Retry landing cl for issue with TSAN. (Closed)

Created:
4 years ago by siva
Modified:
4 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address code review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -155 lines) Patch
M runtime/observatory/tests/service/get_allocation_samples_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/platform/assert.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/tests/vm/vm.status View 2 chunks +28 lines, -27 lines 0 comments Download
M runtime/vm/globals.h View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/os_thread_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_thread_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_thread_macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/profiler.h View 2 chunks +2 lines, -5 lines 0 comments Download
M runtime/vm/profiler.cc View 10 chunks +72 lines, -104 lines 0 comments Download
M runtime/vm/profiler_test.cc View 1 36 chunks +88 lines, -12 lines 0 comments Download
M runtime/vm/stack_frame.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
siva
4 years ago (2016-11-23 22:32:18 UTC) #2
rmacnak
https://codereview.chromium.org/2525103003/diff/1/runtime/vm/profiler_test.cc File runtime/vm/profiler_test.cc (right): https://codereview.chromium.org/2525103003/diff/1/runtime/vm/profiler_test.cc#newcode1577 runtime/vm/profiler_test.cc:1577: /* What's wrong with this one?
4 years ago (2016-11-23 22:48:52 UTC) #3
siva
https://codereview.chromium.org/2525103003/diff/1/runtime/vm/profiler_test.cc File runtime/vm/profiler_test.cc (right): https://codereview.chromium.org/2525103003/diff/1/runtime/vm/profiler_test.cc#newcode1577 runtime/vm/profiler_test.cc:1577: /* On 2016/11/23 22:48:51, rmacnak wrote: > What's wrong ...
4 years ago (2016-11-23 23:07:54 UTC) #4
rmacnak
lgtm
4 years ago (2016-11-23 23:23:42 UTC) #5
siva
4 years ago (2016-11-23 23:40:30 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
501720c644e0be435184f17cbc0e800c70b1b132 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698