Display content_shell error messages.

content/shell/app/shell_main_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/app/shell_main_delegate.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/cpu.h"
 #include "base/files/file.h"
@@ skipping 125 matching lines @@
   v8_breakpad_support::SetUp();
 #endif
 #if defined(OS_MACOSX)
   // Needs to happen before InitializeResourceBundle() and before
   // BlinkTestPlatformInitialize() are called.
   OverrideFrameworkBundlePath();
   OverrideChildProcessPath();
   EnsureCorrectResolutionSettings();
 #endif  // OS_MACOSX
 
-  InitLogging();
+  // Log to stderr when run with --run-layout-tests
+  // so the layout tests can capture and display any messages.
+  if (command_line.HasSwitch(switches::kRunLayoutTest)) {
+    logging::LoggingSettings settings;
+    logging::InitLogging(settings);
+  } else {
+    InitLogging();
+  }

[Dirk Pranke, 2016/12/08 22:09:21]

Having a routine in this file called InitLogging() that is called in one case,
and a routine not in this file called InitLogging that is called in the other is
fairly confusing. 

Does it work if you change this to:

    bool should_log_to_stderr =
command_line.HasSwitch(switches::kRunLayoutTest);
    InitLogging(should_log_to_stderr);

and change the implementation of InitLogging() accordingly?

 

   if (command_line.HasSwitch(switches::kCheckLayoutTestSysDeps)) {
     // If CheckLayoutSystemDeps succeeds, we don't exit early. Instead we
     // continue and try to load the fonts in BlinkTestPlatformInitialize
     // below, and then try to bring up the rest of the content module.
     if (!CheckLayoutSystemDeps()) {
       *exit_code = 1;
       return true;
     }
   }
 
@@ skipping 210 matching lines @@
 
   return renderer_client_.get();
 }
 
 ContentUtilityClient* ShellMainDelegate::CreateContentUtilityClient() {
   utility_client_.reset(new ShellContentUtilityClient);
   return utility_client_.get();
 }
 
 }  // namespace content