Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2525013002: [modules] Propagate module status when creating ParseInfo from SFI. (Closed)

Created:
4 years ago by neis
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, adamk
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Propagate module status when creating ParseInfo from SFI. In the ParseInfo constructor that takes a SharedFunctionInfo, we must set the module flag when the function represents a module. BUG=v8:1569 Committed: https://crrev.com/cde9f7bfedbff818fc05e5c7f723b108de4c6a4a Cr-Commit-Position: refs/heads/master@{#41257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/parsing/parse-info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
neis
ptal
4 years ago (2016-11-23 16:17:18 UTC) #3
neis
+marja: ptal
4 years ago (2016-11-24 09:58:14 UTC) #5
Michael Starzinger
LGTM. Thanks!
4 years ago (2016-11-24 10:21:26 UTC) #7
marja
lgtm
4 years ago (2016-11-24 10:22:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525013002/1
4 years ago (2016-11-24 10:23:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 10:48:46 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-24 10:49:07 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cde9f7bfedbff818fc05e5c7f723b108de4c6a4a
Cr-Commit-Position: refs/heads/master@{#41257}

Powered by Google App Engine
This is Rietveld 408576698