Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2525003006: Language settings: tweak Custom Spelling page (Closed)

Created:
4 years ago by michaelpg
Modified:
4 years ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Language settings: tweak Custom Spelling page Couple minor visual tweaks to the Add Word row; see screenshots at https://crbug.com/630982#17. BUG=630982 R=stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f168619327c17934598e8add95bf5c3f17045519 Cr-Commit-Position: refs/heads/master@{#434827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/resources/settings/languages_page/edit_dictionary_page.html View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
michaelpg
Small CL when you get the chance, no rush.
4 years ago (2016-11-24 03:32:00 UTC) #2
stevenjb
lgtm
4 years ago (2016-11-28 17:41:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525003006/1
4 years ago (2016-11-28 23:18:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 01:57:42 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-29 01:59:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f168619327c17934598e8add95bf5c3f17045519
Cr-Commit-Position: refs/heads/master@{#434827}

Powered by Google App Engine
This is Rietveld 408576698