Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2525003005: [Predator] Move testcase.py from libs/ to gae_libs/ (Closed)

Created:
4 years ago by Sharu Jiang
Modified:
4 years ago
Reviewers:
wrengr, stgao
CC:
chromium-reviews, infra-reviews+infra_chromium.org, chanli, lijeffrey
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Predator] Move testcase.py from libs/ to gae_libs/ Following https://codereview.chromium.org/2521773004/, since the TestCase includes some appengine local testing set up, it should be in gae_libs/ BUG=659449 Committed: https://chromium.googlesource.com/infra/infra/+/d9cdc8afc8913ea2f73456858bb1bf4d271542ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -80 lines) Patch
M appengine/findit/crash/test/crash_testcase.py View 1 chunk +1 line, -1 line 0 comments Download
A + appengine/findit/gae_libs/testcase.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M appengine/findit/lib/gitiles/test/gitiles_repository_test.py View 1 chunk +1 line, -1 line 0 comments Download
D appengine/findit/libs/testcase.py View 1 chunk +0 lines, -77 lines 0 comments Download
M appengine/findit/model/flake/test/flake_analysis_request_test.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/test/wf_testcase.py View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
Sharu Jiang
PTAL :)
4 years ago (2016-11-23 20:53:11 UTC) #3
stgao
lgtm
4 years ago (2016-11-23 21:05:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2525003005/1
4 years ago (2016-11-23 21:13:29 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-23 21:59:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/d9cdc8afc8913ea2f73456858bb1b...

Powered by Google App Engine
This is Rietveld 408576698