Remove plumbing for today value

Remove plumbing for today value

The calendar always sets today to 2011/01/01. This Cl removes the various
DataProviders needed to plumb this value and just sets it where needed.

Committed: https://pdfium.googlesource.com/pdfium/+/209821f79d0bbeeaeadf4e82ff643ee20d676222

[dsinclair, 2016-11-23 15:04:53]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-23 15:04:53]

PTAL.

https://codereview.chromium.org/2524993002/diff/1/xfa/fwl/core/ifwl_datetimep...
File xfa/fwl/core/ifwl_datetimepicker.cpp (left):

https://codereview.chromium.org/2524993002/diff/1/xfa/fwl/core/ifwl_datetimep...
xfa/fwl/core/ifwl_datetimepicker.cpp:39: m_iCurYear(2010),
They have these values to start but as soon as we Update we'll get 2011, so I
went with 2011 dates

[npm, 2016-11-23 15:36:50]

If these are actually being used, wouldn't it be better to actually implement
GetToday to get today's date?

[dsinclair, 2016-11-23 16:34:27]

On 2016/11/23 15:36:50, npm wrote:
> If these are actually being used, wouldn't it be better to actually implement
> GetToday to get today's date?

Probably, but lets leave that for a future cleanup. Getting rid of this makes it
simpler to combine the CFWL and IFWL classes. We can add functionality in where
needed after that's done if we decide this needs to be fixed.

[npm, 2016-11-23 16:42:31]

lgtm

https://codereview.chromium.org/2524993002/diff/1/xfa/fwl/core/ifwl_monthcale...
File xfa/fwl/core/ifwl_monthcalendar.cpp (right):

https://codereview.chromium.org/2524993002/diff/1/xfa/fwl/core/ifwl_monthcale...
xfa/fwl/core/ifwl_monthcalendar.cpp:728: m_iYear = 2011;
Add a TODO?

[dsinclair, 2016-11-23 16:46:40]

https://codereview.chromium.org/2524993002/diff/1/xfa/fwl/core/ifwl_monthcale...
File xfa/fwl/core/ifwl_monthcalendar.cpp (right):

https://codereview.chromium.org/2524993002/diff/1/xfa/fwl/core/ifwl_monthcale...
xfa/fwl/core/ifwl_monthcalendar.cpp:728: m_iYear = 2011;
On 2016/11/23 16:42:31, npm wrote:
> Add a TODO?

Done.

[dsinclair, 2016-11-23 16:46:43]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-23 16:46:43]

The patchset sent to the CQ was uploaded after l-g-t-m from npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2524993002/#ps20001
(title: "Review fixes")

[commit-bot: I haz the power, 2016-11-23 16:46:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 17:02:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479919603271750,
"parent_rev": "1e32d811c1c9f0a729e8072cf3530208cf52e763", "commit_rev":
"209821f79d0bbeeaeadf4e82ff643ee20d676222"}

[commit-bot: I haz the power, 2016-11-23 17:02:38]

Description was changed from

==========
Remove plumbing for today value

The calendar always sets today to 2011/01/01. This Cl removes the various
DataProviders needed to plumb this value and just sets it where needed.
==========

to

==========
Remove plumbing for today value

The calendar always sets today to 2011/01/01. This Cl removes the various
DataProviders needed to plumb this value and just sets it where needed.

Committed:
https://pdfium.googlesource.com/pdfium/+/209821f79d0bbeeaeadf4e82ff643ee20d67...
==========

[commit-bot: I haz the power, 2016-11-23 17:02:40]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/209821f79d0bbeeaeadf4e82ff643ee20d67...