Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2524993002: Remove plumbing for today value (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove plumbing for today value The calendar always sets today to 2011/01/01. This Cl removes the various DataProviders needed to plumb this value and just sets it where needed. Committed: https://pdfium.googlesource.com/pdfium/+/209821f79d0bbeeaeadf4e82ff643ee20d676222

Patch Set 1 #

Total comments: 3

Patch Set 2 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -83 lines) Patch
M xfa/fwl/core/cfwl_datetimepicker.h View 1 chunk +1 line, -7 lines 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.h View 3 chunks +1 line, -17 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.cpp View 4 chunks +0 lines, -27 lines 0 comments Download
M xfa/fwl/core/ifwl_monthcalendar.h View 1 chunk +0 lines, -7 lines 0 comments Download
M xfa/fwl/core/ifwl_monthcalendar.cpp View 1 1 chunk +8 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dsinclair
PTAL. https://codereview.chromium.org/2524993002/diff/1/xfa/fwl/core/ifwl_datetimepicker.cpp File xfa/fwl/core/ifwl_datetimepicker.cpp (left): https://codereview.chromium.org/2524993002/diff/1/xfa/fwl/core/ifwl_datetimepicker.cpp#oldcode39 xfa/fwl/core/ifwl_datetimepicker.cpp:39: m_iCurYear(2010), They have these values to start but ...
4 years ago (2016-11-23 15:04:53 UTC) #2
npm
If these are actually being used, wouldn't it be better to actually implement GetToday to ...
4 years ago (2016-11-23 15:36:50 UTC) #3
dsinclair
On 2016/11/23 15:36:50, npm wrote: > If these are actually being used, wouldn't it be ...
4 years ago (2016-11-23 16:34:27 UTC) #4
npm
lgtm https://codereview.chromium.org/2524993002/diff/1/xfa/fwl/core/ifwl_monthcalendar.cpp File xfa/fwl/core/ifwl_monthcalendar.cpp (right): https://codereview.chromium.org/2524993002/diff/1/xfa/fwl/core/ifwl_monthcalendar.cpp#newcode728 xfa/fwl/core/ifwl_monthcalendar.cpp:728: m_iYear = 2011; Add a TODO?
4 years ago (2016-11-23 16:42:31 UTC) #5
dsinclair
https://codereview.chromium.org/2524993002/diff/1/xfa/fwl/core/ifwl_monthcalendar.cpp File xfa/fwl/core/ifwl_monthcalendar.cpp (right): https://codereview.chromium.org/2524993002/diff/1/xfa/fwl/core/ifwl_monthcalendar.cpp#newcode728 xfa/fwl/core/ifwl_monthcalendar.cpp:728: m_iYear = 2011; On 2016/11/23 16:42:31, npm wrote: > ...
4 years ago (2016-11-23 16:46:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524993002/20001
4 years ago (2016-11-23 16:46:52 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-23 17:02:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/209821f79d0bbeeaeadf4e82ff643ee20d67...

Powered by Google App Engine
This is Rietveld 408576698