Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2524973002: Fix vm-kernel status file after merging kernel. (Closed)

Created:
4 years ago by asgerf
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix vm-kernel status file after merging kernel. The buildbots run tests against the checked-in version of analyzer, not the one in the pubspec, which is why the tests behave differently. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/b0ffc26dab03b611de9171e8eebe3d58122c37d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M tests/language/language_kernel.status View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
asgerf
4 years ago (2016-11-23 13:09:33 UTC) #2
Kevin Millikin (Google)
lgtm
4 years ago (2016-11-23 13:12:14 UTC) #3
kustermann
I thought I changed that this morning in https://github.com/dart-lang/sdk/commit/656be7a7aa11c2a61e357b879d05ed5a1c7d7350
4 years ago (2016-11-23 13:13:20 UTC) #4
asgerf
On 2016/11/23 13:13:20, kustermann wrote: > I thought I changed that this morning in > ...
4 years ago (2016-11-23 13:16:05 UTC) #5
asgerf
4 years ago (2016-11-23 13:19:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b0ffc26dab03b611de9171e8eebe3d58122c37d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698