Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2524953002: [Sensors] The sensor state changes from "active" to "activated" (Closed)

Created:
4 years ago by Mikhail
Modified:
4 years ago
CC:
Reilly Grant (use Gerrit), blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] The sensor state changes from "active" to "activated" The sensor state changes from "active" to "activated" in the latest ED specification [1]. [1] https://w3c.github.io/sensors/#state BUG=667728 Committed: https://crrev.com/12710441dec88821cea09b9ec3bd76802bf3bfdf Cr-Commit-Position: refs/heads/master@{#434454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
Mikhail
PTAL
4 years ago (2016-11-23 11:39:59 UTC) #5
shalamov
lgtm
4 years ago (2016-11-23 12:03:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524953002/1
4 years ago (2016-11-23 13:07:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/320793)
4 years ago (2016-11-23 14:19:22 UTC) #12
Reilly Grant (use Gerrit)
lgtm
4 years ago (2016-11-23 18:25:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524953002/1
4 years ago (2016-11-24 08:24:52 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on ...
4 years ago (2016-11-24 10:26:02 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524953002/1
4 years ago (2016-11-25 07:11:38 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 08:33:52 UTC) #23
commit-bot: I haz the power
4 years ago (2016-11-25 08:37:04 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12710441dec88821cea09b9ec3bd76802bf3bfdf
Cr-Commit-Position: refs/heads/master@{#434454}

Powered by Google App Engine
This is Rietveld 408576698