Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Issue 2524943002: Reland of [stubs] KeyedStoreGeneric: inline dictionary property stores (Closed)

Created:
4 years ago by Jakob Kummerow
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [stubs] KeyedStoreGeneric: inline dictionary property stores For dictionary-mode receivers, the KeyedStoreGeneric stub can store properties directly in most cases. Doing so avoids the need to have an entry in the stub cache for every map/property combination. Original review: https://codereview.chromium.org/2504403005/ Committed: https://crrev.com/7a963deb85a0cc04623947a759534c48e2871901 Cr-Commit-Position: refs/heads/master@{#41218}

Patch Set 1 : original patch #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+532 lines, -84 lines) Patch
M src/builtins/builtins-array.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/code-stub-assembler.h View 1 4 chunks +55 lines, -20 lines 0 comments Download
M src/code-stub-assembler.cc View 1 12 chunks +176 lines, -18 lines 0 comments Download
M src/code-stubs.cc View 1 2 chunks +11 lines, -13 lines 0 comments Download
M src/ic/accessor-assembler.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/ic/keyed-store-generic.cc View 1 5 chunks +254 lines, -20 lines 0 comments Download
M src/objects.h View 1 2 chunks +6 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-private-enumerable.js View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Jakob Kummerow
Created Reland of [stubs] KeyedStoreGeneric: inline dictionary property stores
4 years ago (2016-11-23 09:38:05 UTC) #1
Jakob Kummerow
PTAL.
4 years ago (2016-11-23 11:02:53 UTC) #4
Igor Sheludko
lgtm
4 years ago (2016-11-23 12:06:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524943002/10002
4 years ago (2016-11-23 12:13:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:10002)
4 years ago (2016-11-23 12:43:34 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7a963deb85a0cc04623947a759534c48e2871901 Cr-Commit-Position: refs/heads/master@{#41218}
4 years ago (2016-11-23 12:43:54 UTC) #12
Michael Achenbach
Blocks current roll: https://codereview.chromium.org/2526753003/ Bisect results: https://codereview.chromium.org/2531483002
4 years ago (2016-11-24 08:28:55 UTC) #14
Michael Hablich
4 years ago (2016-11-24 08:30:55 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:10002) has been created in
https://codereview.chromium.org/2522393002/ by hablich@chromium.org.

The reason for reverting is: Blocks current roll:
https://codereview.chromium.org/2526753003/

Bisect results:
https://codereview.chromium.org/2531483002
.

Powered by Google App Engine
This is Rietveld 408576698