Chromium Code Reviews| Index: components/certificate_reporting/cert_logger.proto |
| diff --git a/components/certificate_reporting/cert_logger.proto b/components/certificate_reporting/cert_logger.proto |
| index 644ba99e8462c3bfa007ba85573c1941185ce8a4..fad1fdd3e484c7227403e4f14cc7db9f6987746b 100644 |
| --- a/components/certificate_reporting/cert_logger.proto |
| +++ b/components/certificate_reporting/cert_logger.proto |
| @@ -42,6 +42,9 @@ message CertLoggerInterstitialInfo { |
| optional bool user_proceeded = 2; |
| // True if the user was shown an option to click through |
| optional bool overridable = 3; |
| + // The time (in usec since the epoch) when the client created the |
|
meacer
2016/11/23 23:27:48
nit: Maybe note which epoch this is (unix).
estark
2016/11/24 00:00:16
Done (it's actually windows epoch, unfortunately)
meacer
2016/11/24 00:23:46
Yeah, I remembered this quirk after hitting send.
|
| + // interstiital. |
|
meacer
2016/11/23 23:27:49
spelling
estark
2016/11/24 00:00:16
Done.
|
| + optional int64 interstitial_time_usec = 4; |
|
meacer
2016/11/23 23:27:49
Very minor nit: Perhaps rename to interstitial_cre
estark
2016/11/24 00:00:16
Done.
|
| } |
| // Contains information about features that are enabled/disabled that |
| @@ -73,8 +76,7 @@ message CertLoggerRequest { |
| // The certificate chain as a series of PEM-encoded certificates, including |
| // intermediates but not necessarily the root. |
| required string cert_chain = 2; |
| - // The time (in usec since the epoch) when the client attempted to access the |
| - // site generating the pinning error. |
| + // The time (in usec since the epoch) when the client generated the report. |
| required int64 time_usec = 3; |
| // public_key_hash contains the string forms of the hashes calculated for |
| // the chain. (I.e. "sha1/<base64 data>".) |