Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2524903003:
EDisplay enum class: Rename [Inline]Box to Webkit[Inline]Box. (Closed)
|
Created:
4 years ago by mstensho (USE GERRIT) Modified:
4 years ago Reviewers:
sashab CC:
darktears, apavlov+blink_chromium.org, atotic+reviews_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, cbiesinger, chromium-reviews, dglazkov+blink, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEDisplay enum class: Rename [Inline]Box to Webkit[Inline]Box.
The "box" and "inline-box" values (or rather: "-webkit-box" and
"-webkit-inline-box") for "display" are for an early-stage version of the
flexbox spec, which the web embraced before the flexbox spec got around to
going CR (which uses the values "flex" and "inline-flex" instead).
Furthermore: Having both EDisplay::InlineBox enum value and the InlineBox class
(in Source/core/layout/line/InlineBox.h) confuses the symbol lookup in gdb,
which causes a ~40 seconds freeze [1] when working on something that involves the
InlineBox class.
[1] For component builds with gdb_index set to true in gn
BUG=655961
Committed: https://crrev.com/40d77a4fb4d16dec83ecd5be8c98633ac15b6021
Cr-Commit-Position: refs/heads/master@{#434316}
Patch Set 1 #
Messages
Total messages: 23 (10 generated)
mstensho@opera.com changed reviewers: + sashab@chromium.org
I've got no time for those 40 second waits, so I spent a day fixing it! :)
Nicely done, well done. We should really investigate fixing the underlying cause though.. maybe +cc loyso@ to the bug and see what he thinks. Lgtm for now so gdb is actually usable :) On 24 Nov 2016 7:54 AM, <mstensho@opera.com> wrote: > Reviewers: sashab > CL: https://codereview.chromium.org/2524903003/ > > Message: > I've got no time for those 40 second waits, so I spent a day fixing it! :) > > Description: > EDisplay enum class: Rename [Inline]Box to Webkit[Inline]Box. > > The "box" and "inline-box" values (or rather: "-webkit-box" and > "-webkit-inline-box") for "display" are for an early-stage version of the > flexbox spec, which the web embraced before the flexbox spec got around to > going CR (which uses the values "flex" and "inline-flex" instead). > > Furthermore: Having both EDisplay::InlineBox enum value and the InlineBox > class > (in Source/core/layout/line/InlineBox.h) confuses the symbol lookup in > gdb, > which causes a ~40 seconds freeze [1] when working on something that > involves > the > InlineBox class. > > [1] For component builds with gdb_index set to true in gn > > BUG=655961 > > Affected files (+16, -15 lines): > M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h > M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp > M third_party/WebKit/Source/core/layout/LayoutObject.h > M third_party/WebKit/Source/core/layout/LayoutObject.cpp > M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc > M third_party/WebKit/Source/core/style/ComputedStyle.h > M third_party/WebKit/Source/core/style/ComputedStyleConstants.h > > > Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h > diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h > b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h > index d07e922b17333765f11d8ecb349699fcc6a3bcde.. > c18e635b137f9b291407a50f666f8950c3045fb4 100644 > --- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h > +++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h > @@ -1242,10 +1242,10 @@ inline CSSIdentifierValue::CSSIdentifierValue(EDisplay > e) > case EDisplay::TableCaption: > m_valueID = CSSValueTableCaption; > break; > - case EDisplay::Box: > + case EDisplay::WebkitBox: > m_valueID = CSSValueWebkitBox; > break; > - case EDisplay::InlineBox: > + case EDisplay::WebkitInlineBox: > m_valueID = CSSValueWebkitInlineBox; > break; > case EDisplay::Flex: > Index: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp > diff --git a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp > b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp > index d125cb141bc58ed6ed8f880c43fb5ff8271a405a.. > 615341c661e673ae84561e230ac29c0836194158 100644 > --- a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp > +++ b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp > @@ -59,15 +59,15 @@ static EDisplay equivalentBlockDisplay(EDisplay > display) { > switch (display) { > case EDisplay::Block: > case EDisplay::Table: > - case EDisplay::Box: > + case EDisplay::WebkitBox: > case EDisplay::Flex: > case EDisplay::Grid: > case EDisplay::ListItem: > return display; > case EDisplay::InlineTable: > return EDisplay::Table; > - case EDisplay::InlineBox: > - return EDisplay::Box; > + case EDisplay::WebkitInlineBox: > + return EDisplay::WebkitBox; > case EDisplay::InlineFlex: > return EDisplay::Flex; > case EDisplay::InlineGrid: > @@ -106,7 +106,7 @@ static bool doesNotInheritTextDecoration(const > ComputedStyle& style, > const Element* element) { > return style.display() == EDisplay::InlineTable || > style.display() == EDisplay::InlineBlock || > - style.display() == EDisplay::InlineBox || > + style.display() == EDisplay::WebkitInlineBox || > isAtShadowBoundary(element) || style.isFloating() || > style.hasOutOfFlowPosition() || isOutermostSVGElement(element) || > isHTMLRTElement(element); > @@ -364,8 +364,8 @@ static void adjustStyleForDisplay(ComputedStyle& > style, > // setting of block-flow to anything other than TopToBottomWritingMode. > // https://bugs.webkit.org/show_bug.cgi?id=46418 - Flexible box support. > if (style.getWritingMode() != TopToBottomWritingMode && > - (style.display() == EDisplay::Box || > - style.display() == EDisplay::InlineBox)) > + (style.display() == EDisplay::WebkitBox || > + style.display() == EDisplay::WebkitInlineBox)) > style.setWritingMode(TopToBottomWritingMode); > > if (parentStyle.isDisplayFlexibleOrGridBox()) { > Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp > diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp > b/third_party/WebKit/Source/core/layout/LayoutObject.cpp > index 1785f378be07b67864566d4bd11644377e68283e.. > 82fd7a15caf2c0a69efa1ce741f551079e423a5f 100644 > --- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp > +++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp > @@ -204,8 +204,8 @@ LayoutObject* LayoutObject::createObject(Element* > element, > return new LayoutTableCell(element); > case EDisplay::TableCaption: > return new LayoutTableCaption(element); > - case EDisplay::Box: > - case EDisplay::InlineBox: > + case EDisplay::WebkitBox: > + case EDisplay::WebkitInlineBox: > return new LayoutDeprecatedFlexibleBox(*element); > case EDisplay::Flex: > case EDisplay::InlineFlex: > Index: third_party/WebKit/Source/core/layout/LayoutObject.h > diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h > b/third_party/WebKit/Source/core/layout/LayoutObject.h > index 8478f86e332c7f6041d231b7552db5f38e8c24dc.. > 35a79dc18896a23597b58d863053c65f0b1961e0 100644 > --- a/third_party/WebKit/Source/core/layout/LayoutObject.h > +++ b/third_party/WebKit/Source/core/layout/LayoutObject.h > @@ -709,7 +709,7 @@ class CORE_EXPORT LayoutObject : public > ImageResourceObserver, > // LayoutTextFragment are not LayoutBlocks and will return false. > // See https://bugs.webkit.org/show_bug.cgi?id=56709. > return isAnonymous() && (style()->display() == EDisplay::Block || > - style()->display() == EDisplay::Box) && > + style()->display() == EDisplay::WebkitBox) && > style()->styleType() == PseudoIdNone && isLayoutBlock() && > !isListMarker() && !isLayoutFlowThread() && > !isLayoutMultiColumnSet() && !isLayoutFullScreen() && > Index: third_party/WebKit/Source/core/layout/ng/ng_block_ > layout_algorithm.cc > diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc > b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc > index 6d83e37de5c453f60eea907d260f0c83936df901.. > 0890ba12547e18c92e06313ef122035d39f6eb52 100644 > --- a/third_party/WebKit/Source/core/layout/ng/ng_block_ > layout_algorithm.cc > +++ b/third_party/WebKit/Source/core/layout/ng/ng_block_ > layout_algorithm.cc > @@ -164,7 +164,7 @@ bool IsNewFormattingContextForInFlowBlockLevelChild( > > EDisplay display = style.display(); > if (display == EDisplay::Grid || display == EDisplay::Flex || > - display == EDisplay::Box) > + display == EDisplay::WebkitBox) > return true; > > if (space.WritingMode() != FromPlatformWritingMode(style. > getWritingMode())) > Index: third_party/WebKit/Source/core/style/ComputedStyle.h > diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h > b/third_party/WebKit/Source/core/style/ComputedStyle.h > index 31573b94f4585262fd459c213041aa2e6016af2b.. > b22f0fe24c53a1eda5dea82b32e76542cad115c3 100644 > --- a/third_party/WebKit/Source/core/style/ComputedStyle.h > +++ b/third_party/WebKit/Source/core/style/ComputedStyle.h > @@ -3900,7 +3900,8 @@ class CORE_EXPORT ComputedStyle : public > ComputedStyleBase, > } > > static bool isDisplayReplacedType(EDisplay display) { > - return display == EDisplay::InlineBlock || display == > EDisplay::InlineBox || > + return display == EDisplay::InlineBlock || > + display == EDisplay::WebkitInlineBox || > display == EDisplay::InlineFlex || > display == EDisplay::InlineTable || display == EDisplay::InlineGrid; > } > Index: third_party/WebKit/Source/core/style/ComputedStyleConstants.h > diff --git a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h > b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h > index 383dfc3c9ba98dc37dc3eba634a6d69cc8c5a3d7.. > 2b04b7dc6237001161a81080abcd429d3554f536 100644 > --- a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h > +++ b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h > @@ -490,8 +490,8 @@ enum class EDisplay : unsigned { > TableColumn, > TableCell, > TableCaption, > - Box, > - InlineBox, > + WebkitBox, > + WebkitInlineBox, > Flex, > InlineFlex, > Grid, > > > -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Nicely done, well done. We should really investigate fixing the underlying cause though.. maybe +cc loyso@ to the bug and see what he thinks. Lgtm for now so gdb is actually usable :) On 24 Nov 2016 7:54 AM, <mstensho@opera.com> wrote: > Reviewers: sashab > CL: https://codereview.chromium.org/2524903003/ > > Message: > I've got no time for those 40 second waits, so I spent a day fixing it! :) > > Description: > EDisplay enum class: Rename [Inline]Box to Webkit[Inline]Box. > > The "box" and "inline-box" values (or rather: "-webkit-box" and > "-webkit-inline-box") for "display" are for an early-stage version of the > flexbox spec, which the web embraced before the flexbox spec got around to > going CR (which uses the values "flex" and "inline-flex" instead). > > Furthermore: Having both EDisplay::InlineBox enum value and the InlineBox > class > (in Source/core/layout/line/InlineBox.h) confuses the symbol lookup in > gdb, > which causes a ~40 seconds freeze [1] when working on something that > involves > the > InlineBox class. > > [1] For component builds with gdb_index set to true in gn > > BUG=655961 > > Affected files (+16, -15 lines): > M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h > M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp > M third_party/WebKit/Source/core/layout/LayoutObject.h > M third_party/WebKit/Source/core/layout/LayoutObject.cpp > M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc > M third_party/WebKit/Source/core/style/ComputedStyle.h > M third_party/WebKit/Source/core/style/ComputedStyleConstants.h > > > Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h > diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h > b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h > index d07e922b17333765f11d8ecb349699fcc6a3bcde.. > c18e635b137f9b291407a50f666f8950c3045fb4 100644 > --- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h > +++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h > @@ -1242,10 +1242,10 @@ inline CSSIdentifierValue::CSSIdentifierValue(EDisplay > e) > case EDisplay::TableCaption: > m_valueID = CSSValueTableCaption; > break; > - case EDisplay::Box: > + case EDisplay::WebkitBox: > m_valueID = CSSValueWebkitBox; > break; > - case EDisplay::InlineBox: > + case EDisplay::WebkitInlineBox: > m_valueID = CSSValueWebkitInlineBox; > break; > case EDisplay::Flex: > Index: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp > diff --git a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp > b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp > index d125cb141bc58ed6ed8f880c43fb5ff8271a405a.. > 615341c661e673ae84561e230ac29c0836194158 100644 > --- a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp > +++ b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp > @@ -59,15 +59,15 @@ static EDisplay equivalentBlockDisplay(EDisplay > display) { > switch (display) { > case EDisplay::Block: > case EDisplay::Table: > - case EDisplay::Box: > + case EDisplay::WebkitBox: > case EDisplay::Flex: > case EDisplay::Grid: > case EDisplay::ListItem: > return display; > case EDisplay::InlineTable: > return EDisplay::Table; > - case EDisplay::InlineBox: > - return EDisplay::Box; > + case EDisplay::WebkitInlineBox: > + return EDisplay::WebkitBox; > case EDisplay::InlineFlex: > return EDisplay::Flex; > case EDisplay::InlineGrid: > @@ -106,7 +106,7 @@ static bool doesNotInheritTextDecoration(const > ComputedStyle& style, > const Element* element) { > return style.display() == EDisplay::InlineTable || > style.display() == EDisplay::InlineBlock || > - style.display() == EDisplay::InlineBox || > + style.display() == EDisplay::WebkitInlineBox || > isAtShadowBoundary(element) || style.isFloating() || > style.hasOutOfFlowPosition() || isOutermostSVGElement(element) || > isHTMLRTElement(element); > @@ -364,8 +364,8 @@ static void adjustStyleForDisplay(ComputedStyle& > style, > // setting of block-flow to anything other than TopToBottomWritingMode. > // https://bugs.webkit.org/show_bug.cgi?id=46418 - Flexible box support. > if (style.getWritingMode() != TopToBottomWritingMode && > - (style.display() == EDisplay::Box || > - style.display() == EDisplay::InlineBox)) > + (style.display() == EDisplay::WebkitBox || > + style.display() == EDisplay::WebkitInlineBox)) > style.setWritingMode(TopToBottomWritingMode); > > if (parentStyle.isDisplayFlexibleOrGridBox()) { > Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp > diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp > b/third_party/WebKit/Source/core/layout/LayoutObject.cpp > index 1785f378be07b67864566d4bd11644377e68283e.. > 82fd7a15caf2c0a69efa1ce741f551079e423a5f 100644 > --- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp > +++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp > @@ -204,8 +204,8 @@ LayoutObject* LayoutObject::createObject(Element* > element, > return new LayoutTableCell(element); > case EDisplay::TableCaption: > return new LayoutTableCaption(element); > - case EDisplay::Box: > - case EDisplay::InlineBox: > + case EDisplay::WebkitBox: > + case EDisplay::WebkitInlineBox: > return new LayoutDeprecatedFlexibleBox(*element); > case EDisplay::Flex: > case EDisplay::InlineFlex: > Index: third_party/WebKit/Source/core/layout/LayoutObject.h > diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h > b/third_party/WebKit/Source/core/layout/LayoutObject.h > index 8478f86e332c7f6041d231b7552db5f38e8c24dc.. > 35a79dc18896a23597b58d863053c65f0b1961e0 100644 > --- a/third_party/WebKit/Source/core/layout/LayoutObject.h > +++ b/third_party/WebKit/Source/core/layout/LayoutObject.h > @@ -709,7 +709,7 @@ class CORE_EXPORT LayoutObject : public > ImageResourceObserver, > // LayoutTextFragment are not LayoutBlocks and will return false. > // See https://bugs.webkit.org/show_bug.cgi?id=56709. > return isAnonymous() && (style()->display() == EDisplay::Block || > - style()->display() == EDisplay::Box) && > + style()->display() == EDisplay::WebkitBox) && > style()->styleType() == PseudoIdNone && isLayoutBlock() && > !isListMarker() && !isLayoutFlowThread() && > !isLayoutMultiColumnSet() && !isLayoutFullScreen() && > Index: third_party/WebKit/Source/core/layout/ng/ng_block_ > layout_algorithm.cc > diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc > b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc > index 6d83e37de5c453f60eea907d260f0c83936df901.. > 0890ba12547e18c92e06313ef122035d39f6eb52 100644 > --- a/third_party/WebKit/Source/core/layout/ng/ng_block_ > layout_algorithm.cc > +++ b/third_party/WebKit/Source/core/layout/ng/ng_block_ > layout_algorithm.cc > @@ -164,7 +164,7 @@ bool IsNewFormattingContextForInFlowBlockLevelChild( > > EDisplay display = style.display(); > if (display == EDisplay::Grid || display == EDisplay::Flex || > - display == EDisplay::Box) > + display == EDisplay::WebkitBox) > return true; > > if (space.WritingMode() != FromPlatformWritingMode(style. > getWritingMode())) > Index: third_party/WebKit/Source/core/style/ComputedStyle.h > diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h > b/third_party/WebKit/Source/core/style/ComputedStyle.h > index 31573b94f4585262fd459c213041aa2e6016af2b.. > b22f0fe24c53a1eda5dea82b32e76542cad115c3 100644 > --- a/third_party/WebKit/Source/core/style/ComputedStyle.h > +++ b/third_party/WebKit/Source/core/style/ComputedStyle.h > @@ -3900,7 +3900,8 @@ class CORE_EXPORT ComputedStyle : public > ComputedStyleBase, > } > > static bool isDisplayReplacedType(EDisplay display) { > - return display == EDisplay::InlineBlock || display == > EDisplay::InlineBox || > + return display == EDisplay::InlineBlock || > + display == EDisplay::WebkitInlineBox || > display == EDisplay::InlineFlex || > display == EDisplay::InlineTable || display == EDisplay::InlineGrid; > } > Index: third_party/WebKit/Source/core/style/ComputedStyleConstants.h > diff --git a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h > b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h > index 383dfc3c9ba98dc37dc3eba634a6d69cc8c5a3d7.. > 2b04b7dc6237001161a81080abcd429d3554f536 100644 > --- a/third_party/WebKit/Source/core/style/ComputedStyleConstants.h > +++ b/third_party/WebKit/Source/core/style/ComputedStyleConstants.h > @@ -490,8 +490,8 @@ enum class EDisplay : unsigned { > TableColumn, > TableCell, > TableCaption, > - Box, > - InlineBox, > + WebkitBox, > + WebkitInlineBox, > Flex, > InlineFlex, > Grid, > > > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
lgtm
The CQ bit was checked by mstensho@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mstensho@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by mstensho@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by mstensho@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479987445494770, "parent_rev":
"a006185a7f6acb1fa7b0b55bb2bbbfa7097a08a8", "commit_rev":
"de4507de3cab4f6a2ff8ed3b442d1fb92ab94127"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== EDisplay enum class: Rename [Inline]Box to Webkit[Inline]Box. The "box" and "inline-box" values (or rather: "-webkit-box" and "-webkit-inline-box") for "display" are for an early-stage version of the flexbox spec, which the web embraced before the flexbox spec got around to going CR (which uses the values "flex" and "inline-flex" instead). Furthermore: Having both EDisplay::InlineBox enum value and the InlineBox class (in Source/core/layout/line/InlineBox.h) confuses the symbol lookup in gdb, which causes a ~40 seconds freeze [1] when working on something that involves the InlineBox class. [1] For component builds with gdb_index set to true in gn BUG=655961 ========== to ========== EDisplay enum class: Rename [Inline]Box to Webkit[Inline]Box. The "box" and "inline-box" values (or rather: "-webkit-box" and "-webkit-inline-box") for "display" are for an early-stage version of the flexbox spec, which the web embraced before the flexbox spec got around to going CR (which uses the values "flex" and "inline-flex" instead). Furthermore: Having both EDisplay::InlineBox enum value and the InlineBox class (in Source/core/layout/line/InlineBox.h) confuses the symbol lookup in gdb, which causes a ~40 seconds freeze [1] when working on something that involves the InlineBox class. [1] For component builds with gdb_index set to true in gn BUG=655961 Committed: https://crrev.com/40d77a4fb4d16dec83ecd5be8c98633ac15b6021 Cr-Commit-Position: refs/heads/master@{#434316} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/40d77a4fb4d16dec83ecd5be8c98633ac15b6021 Cr-Commit-Position: refs/heads/master@{#434316} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
