Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2524903002: Rename AstFactory -> AstTestFactory. (Closed)

Created:
4 years ago by Paul Berry
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename AstFactory -> AstTestFactory. This paves the way for introducing a new AstFactory class that will be part of the analyzer public API. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/05a6045674a4a2576c47b50758492d07858240a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3270 lines, -4234 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 5 chunks +5 lines, -5 lines 0 comments Download
D pkg/analyzer/lib/src/generated/testing/ast_factory.dart View 1 chunk +0 lines, -1294 lines 0 comments Download
A + pkg/analyzer/lib/src/generated/testing/ast_test_factory.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 5 chunks +12 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 20 chunks +48 lines, -45 lines 0 comments Download
M pkg/analyzer/test/dart/ast/ast_test.dart View 35 chunks +259 lines, -224 lines 0 comments Download
M pkg/analyzer/test/dart/element/builder_test.dart View 57 chunks +231 lines, -215 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 7 chunks +14 lines, -14 lines 0 comments Download
M pkg/analyzer/test/generated/analysis_context_factory.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/element_resolver_test.dart View 46 chunks +127 lines, -118 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 10 chunks +23 lines, -22 lines 0 comments Download
M pkg/analyzer/test/generated/inheritance_manager_test.dart View 13 chunks +18 lines, -18 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 40 chunks +107 lines, -97 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_analyzer_test.dart View 76 chunks +184 lines, -175 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 32 chunks +277 lines, -227 lines 0 comments Download
M pkg/analyzer/test/src/dart/ast/utilities_test.dart View 44 chunks +1811 lines, -1617 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/evaluation_test.dart View 9 chunks +33 lines, -33 lines 0 comments Download
M pkg/analyzer/test/src/dart/constant/utilities_test.dart View 11 chunks +35 lines, -34 lines 0 comments Download
M pkg/analyzer/test/src/dart/element/element_test.dart View 30 chunks +50 lines, -50 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years ago (2016-11-22 23:35:57 UTC) #2
Brian Wilkerson
Seems like a lot of unnecessary changes, given that the new class will be in ...
4 years ago (2016-11-23 00:01:05 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 05a6045674a4a2576c47b50758492d07858240a9 (presubmit successful).
4 years ago (2016-11-23 00:09:57 UTC) #5
scheglov
4 years ago (2016-11-23 02:33:19 UTC) #6
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698