Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2524883002: Disable WebVR presentation for Cardboard viewers. (Closed)

Created:
4 years, 1 month ago by mthiesse
Modified:
4 years, 1 month ago
Reviewers:
bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WebVR presentation for Cardboard viewers. BUG=667908 Committed: https://crrev.com/197a42ece84e4dbb583290d53f28b5501dc43619 Cr-Commit-Position: refs/heads/master@{#434023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mthiesse
PTAL
4 years, 1 month ago (2016-11-22 22:32:37 UTC) #2
bshe
On 2016/11/22 22:32:37, mthiesse wrote: > PTAL lgtm
4 years, 1 month ago (2016-11-22 23:00:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524883002/1
4 years, 1 month ago (2016-11-22 23:03:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 23:41:09 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 23:45:00 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/197a42ece84e4dbb583290d53f28b5501dc43619
Cr-Commit-Position: refs/heads/master@{#434023}

Powered by Google App Engine
This is Rietveld 408576698