Rename WindowTreeHost G|SetBounds to indicate they are in pixels.

Rename WindowTreeHost G|SetBounds to indicate they are in pixels.

BUG=664212
TEST=covered by tests

Committed: https://crrev.com/dfdfc99ed90f23a71e37eca0320e2c2c687efa41
Cr-Commit-Position: refs/heads/master@{#434904}

[riajiang, 2016-11-22 21:17:26]

The CQ bit was checked by riajiang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 21:18:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[riajiang, 2016-11-22 21:30:23]

riajiang@chromium.org changed reviewers:
+ sky@chromium.org

[riajiang, 2016-11-22 21:30:24]

Hi sky@, PTAL. Thanks!

[commit-bot: I haz the power, 2016-11-22 21:35:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 21:35:28]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)

[sky, 2016-11-22 21:38:14]

sky@chromium.org changed reviewers:
+ sadrul@chromium.org

[sky, 2016-11-22 21:38:16]

Can you add InPixels more widely? If you want to do this in steps, that's fine
too. Just let me know what you prefer.

I'm also adding Sadrul to make sure he is OK with all these changes to
WwindowTreeHost.

https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h
File ui/aura/window_tree_host.h (right):

https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
ui/aura/window_tree_host.h:55: static WindowTreeHost* Create(const gfx::Rect&
bounds);
rename this to bounds_in_pixels too.

https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
ui/aura/window_tree_host.h:103: void ConvertPointToNativeScreen(gfx::Point*
point) const;
All of these should be InPixels too.

https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
ui/aura/window_tree_host.h:127: void MoveCursorTo(const gfx::Point& location);
LocationInPixels

https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
ui/aura/window_tree_host.h:130: void MoveCursorToHostLocation(const gfx::Point&
host_location);
InPixels

https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
ui/aura/window_tree_host.h:198: virtual gfx::Point GetLocationOnNativeScreen()
const = 0;
GetLocationOnNativeScreenInPixels.

https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
ui/aura/window_tree_host.h:200: void OnHostMoved(const gfx::Point&
new_location);
OnHostMovedInPixels

https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
ui/aura/window_tree_host.h:201: void OnHostResized(const gfx::Size& new_size);
OnHostResizedInPixels

https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
ui/aura/window_tree_host.h:211: virtual void MoveCursorToNative(const
gfx::Point& location) = 0;
MoveCursorToNativeLocationInPixels.

[riajiang, 2016-11-22 22:29:15]

Patchset #2 (id:20001) has been deleted

[riajiang, 2016-11-22 22:33:21]

On 2016/11/22 21:38:16, sky wrote:
> Can you add InPixels more widely? If you want to do this in steps, that's fine
> too. Just let me know what you prefer.
> 
> I'm also adding Sadrul to make sure he is OK with all these changes to
> WwindowTreeHost.
> 
> https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h
> File ui/aura/window_tree_host.h (right):
> 
>
https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
> ui/aura/window_tree_host.h:55: static WindowTreeHost* Create(const gfx::Rect&
> bounds);
> rename this to bounds_in_pixels too.
> 
>
https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
> ui/aura/window_tree_host.h:103: void ConvertPointToNativeScreen(gfx::Point*
> point) const;
> All of these should be InPixels too.
> 
>
https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
> ui/aura/window_tree_host.h:127: void MoveCursorTo(const gfx::Point& location);
> LocationInPixels
> 
>
https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
> ui/aura/window_tree_host.h:130: void MoveCursorToHostLocation(const
gfx::Point&
> host_location);
> InPixels
> 
>
https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
> ui/aura/window_tree_host.h:198: virtual gfx::Point GetLocationOnNativeScreen()
> const = 0;
> GetLocationOnNativeScreenInPixels.
> 
>
https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
> ui/aura/window_tree_host.h:200: void OnHostMoved(const gfx::Point&
> new_location);
> OnHostMovedInPixels
> 
>
https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
> ui/aura/window_tree_host.h:201: void OnHostResized(const gfx::Size& new_size);
> OnHostResizedInPixels
> 
>
https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
> ui/aura/window_tree_host.h:211: virtual void MoveCursorToNative(const
> gfx::Point& location) = 0;
> MoveCursorToNativeLocationInPixels.

Changed from "InPixel" to "InPixels". For other places in WindowTreeHost, I was
thinking 
to have one CL for all non-virtual functions and then separate CLs for each pure
virtual 
function renames? What do you think?

[riajiang, 2016-11-22 22:34:43]

Description was changed from

==========
Rename WindowTreeHost functions to indicate they are in pixels.

BUG=664212
TEST=covered by tests
==========

to

==========
Rename WindowTreeHost G|SetBounds to indicate they are in pixels.

BUG=664212
TEST=covered by tests
==========

[sky, 2016-11-22 23:33:32]

LGTM

[riajiang, 2016-11-22 23:36:05]

riajiang@chromium.org changed reviewers:
+ dtrainor@chromium.org, mkwst@chromium.org

[riajiang, 2016-11-22 23:36:06]

+mkwst@ for content/shell and +dtrainor@ for blimp, thanks!

[riajiang, 2016-11-22 23:36:40]

The CQ bit was checked by riajiang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 23:37:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 00:27:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 00:27:46]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[sadrul, 2016-11-23 03:08:20]

> For other places in WindowTreeHost, I was
> thinking 
> to have one CL for all non-virtual functions and then separate CLs for each
pure
> virtual 
> function renames? What do you think?

Sounds reasonable. It would be good to avoid too much churn though. So it'd make
sense to bunch multiple mechanical updates in a single CL as long as it doesn't
grow too large (e.g. a couple of hundred lines).

lgtm

https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h
File ui/aura/window_tree_host.h (right):

https://codereview.chromium.org/2524873002/diff/1/ui/aura/window_tree_host.h#...
ui/aura/window_tree_host.h:99: virtual void UpdateRootWindowSize(const
gfx::Size& host_size);
Update this too in a follow up CL.

[Mike West, 2016-11-23 09:43:30]

//content/shell LGTM.

[riajiang, 2016-11-23 15:34:54]

riajiang@chromium.org changed reviewers:
+ nyquist@chromium.org
- dtrainor@chromium.org

[riajiang, 2016-11-23 15:34:55]

-dtrainor@ and +nyquist@ as dtrainor@ is OOO

[nyquist, 2016-11-28 23:46:09]

blimp lgtm

[riajiang, 2016-11-29 03:34:07]

The CQ bit was checked by riajiang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 03:34:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 05:32:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 05:32:35]

Dry run: This issue passed the CQ dry run.

[riajiang, 2016-11-29 05:32:46]

The CQ bit was checked by riajiang@chromium.org

[riajiang, 2016-11-29 05:32:46]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
mkwst@chromium.org, sadrul@chromium.org, nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/2524873002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-29 05:32:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 05:37:52]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480397566264690,
"parent_rev": "4cf8ece81b7527701dd66e6b22de9905b7aef54b", "commit_rev":
"971ef57a5f816d985e395554893ec150217a00f9"}

[commit-bot: I haz the power, 2016-11-29 05:38:22]

Description was changed from

==========
Rename WindowTreeHost G|SetBounds to indicate they are in pixels.

BUG=664212
TEST=covered by tests
==========

to

==========
Rename WindowTreeHost G|SetBounds to indicate they are in pixels.

BUG=664212
TEST=covered by tests
==========

[commit-bot: I haz the power, 2016-11-29 05:38:23]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-11-29 05:40:23]

Description was changed from

==========
Rename WindowTreeHost G|SetBounds to indicate they are in pixels.

BUG=664212
TEST=covered by tests
==========

to

==========
Rename WindowTreeHost G|SetBounds to indicate they are in pixels.

BUG=664212
TEST=covered by tests

Committed: https://crrev.com/dfdfc99ed90f23a71e37eca0320e2c2c687efa41
Cr-Commit-Position: refs/heads/master@{#434904}
==========

[commit-bot: I haz the power, 2016-11-29 05:40:24]

Patchset 4 (id:??) landed as
https://crrev.com/dfdfc99ed90f23a71e37eca0320e2c2c687efa41
Cr-Commit-Position: refs/heads/master@{#434904}