Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2524843003: WebView: Add scheme whitelist for content intents. (Closed)

Created:
4 years ago by Torne
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebView: Add scheme whitelist for content intents. Use the content intent scheme whitelist introduced in https://codereview.chromium.org/2448363003 in WebView, which overrides the default implementation. BUG=659477 Committed: https://crrev.com/1825e488888decae9be34ea17a22c92a5e890874 Cr-Commit-Position: refs/heads/master@{#434325}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java View 2 chunks +20 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Torne
Followup to https://codereview.chromium.org/2448363003 to make it apply the same check to WebView. Refactored the base ...
4 years ago (2016-11-23 13:37:47 UTC) #2
Ted C
lgtm
4 years ago (2016-11-23 17:36:11 UTC) #7
sgurun-gerrit only
On 2016/11/23 17:36:11, Ted C wrote: > lgtm lgtm
4 years ago (2016-11-23 17:59:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524843003/1
4 years ago (2016-11-24 12:01:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-24 14:02:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524843003/1
4 years ago (2016-11-24 14:44:33 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 15:20:24 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-24 15:22:55 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1825e488888decae9be34ea17a22c92a5e890874
Cr-Commit-Position: refs/heads/master@{#434325}

Powered by Google App Engine
This is Rietveld 408576698