Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2524833002: Revert of CompositorViewHolder is source of truth for viewports (Closed)

Created:
4 years ago by Maria
Modified:
4 years ago
CC:
agrieve+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of CompositorViewHolder is source of truth for viewports (patchset #5 id:80001 of https://codereview.chromium.org/2509873003/ ) Reason for revert: Broke the builder: https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/11030 Original issue's description: > CompositorViewHolder is source of truth for viewports > > This change makes the CompositorViewHolder responsible for knowing > what the window and visible viewports are. Any class that needs to > know this information can pull it from the CompositorViewHolder > (a LayoutManagerHost) instead of having it pushed or caching it. > This removes a fair amount of state and complication in > LayoutManager. > > BUG=662427 > > Committed: https://crrev.com/fd6719290c9dce87292ea653ac370542014030c7 > Cr-Commit-Position: refs/heads/master@{#433916} TBR=aelias@chromium.org,dtrainor@chromium.org,mdjones@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=662427 Committed: https://crrev.com/af2850cc8821a3fec3fa6608b0aeed88a8eb947e Cr-Commit-Position: refs/heads/master@{#433937}

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
Maria
Created Revert of CompositorViewHolder is source of truth for viewports
4 years ago (2016-11-22 19:10:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524833002/1
4 years ago (2016-11-22 19:11:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-22 19:12:33 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-22 19:16:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af2850cc8821a3fec3fa6608b0aeed88a8eb947e
Cr-Commit-Position: refs/heads/master@{#433937}

Powered by Google App Engine
This is Rietveld 408576698