Chromium Code Reviews
DescriptionRevert of CompositorViewHolder is source of truth for viewports (patchset #5 id:80001 of https://codereview.chromium.org/2509873003/ )
Reason for revert:
Broke the builder: https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/11030
Original issue's description:
> CompositorViewHolder is source of truth for viewports
>
> This change makes the CompositorViewHolder responsible for knowing
> what the window and visible viewports are. Any class that needs to
> know this information can pull it from the CompositorViewHolder
> (a LayoutManagerHost) instead of having it pushed or caching it.
> This removes a fair amount of state and complication in
> LayoutManager.
>
> BUG=662427
>
> Committed: https://crrev.com/fd6719290c9dce87292ea653ac370542014030c7
> Cr-Commit-Position: refs/heads/master@{#433916}
TBR=aelias@chromium.org,dtrainor@chromium.org,mdjones@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=662427
Committed: https://crrev.com/af2850cc8821a3fec3fa6608b0aeed88a8eb947e
Cr-Commit-Position: refs/heads/master@{#433937}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||