WebKit: remove DCHECK_IS_ON from FileWriterSync.

WebKit: remove DCHECK_IS_ON from FileWriterSync.

This CL removes checks for DCHECK_IS_ON in FileWriterSync as they are not used.
(DCHECK macro requires its arguments to be buildable even if check itself is
disabled.) So this CL fixes build in case we want debug build with DCHECKs
disabled.

R=nhiroki@chromium.org

BUG=666660
Committed: https://crrev.com/c9600cd059f7aa0231a89fa2817c4ffca0454122
Cr-Commit-Position: refs/heads/master@{#436473}

[Alexander Alekseev, 2016-11-23 07:19:29]

This is third_party/WebKit/Source/modules/filesystem/ part of
https://codereview.chromium.org/2513893002/ .

Please review.

[haraken, 2016-11-23 08:15:59]

I'm not sure if it's a good idea to increase sizeof(DOM object) for dcheck-only
variables.

In this specific case, sizeof(FileWriterSync) won't matter though.

[nhiroki, 2016-11-24 06:05:07]

LGTM unless this doesn't degrade performance.

On 2016/11/23 08:15:59, haraken wrote:
> I'm not sure if it's a good idea to increase sizeof(DOM object) for
dcheck-only
> variables.
> 
> In this specific case, sizeof(FileWriterSync) won't matter though.

It'd be nice if there is a more handy mechanism to check something only on debug
builds.

[Alexander Alekseev, 2016-11-24 06:20:07]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-11-24 06:20:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 07:41:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 07:41:45]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexander Alekseev, 2016-11-29 04:51:40]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-11-29 04:51:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 04:58:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 04:58:01]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Alexander Alekseev, 2016-11-30 04:05:01]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-11-30 04:05:02]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2524813003/#ps20001
(title: "After git cl format")

[commit-bot: I haz the power, 2016-11-30 04:05:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 06:06:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 06:06:34]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Alexander Alekseev, 2016-12-01 07:19:59]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-12-01 07:20:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 10:29:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 10:29:19]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Alexander Alekseev, 2016-12-02 07:11:23]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 07:11:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 10:50:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 10:50:25]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2016-12-02 12:18:29]

Hiroki, PTAL.

I put back all #ifdef DCHECK_IS_ON() because of Windows trybot. It looks like a
race condition, or something that I cannot debug (I don't have Windows machine
to test that).

What do you think?

[nhiroki, 2016-12-05 11:07:19]

On 2016/12/02 12:18:29, Alexander Alekseev wrote:
> Hiroki, PTAL.
> 
> I put back all #ifdef DCHECK_IS_ON() because of Windows trybot. It looks like
a
> race condition, or something that I cannot debug (I don't have Windows machine
> to test that).
> 
> What do you think?

I ran your PatchSet-3 on trybots and apparently it's working well:
https://codereview.chromium.org/2549063002/

Could you try to land it again?

[Alexander Alekseev, 2016-12-05 22:51:51]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 22:52:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 00:27:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 00:27:05]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2016-12-06 00:40:45]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-12-06 00:40:46]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2524813003/#ps80001
(title: "Reverted "Guard with #ifdefs"")

[commit-bot: I haz the power, 2016-12-06 00:41:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 00:45:37]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1480984845591500,
"parent_rev": "0451e67999b475d57f9bbd2e8e113335811a08cf", "commit_rev":
"91688a0f1f8c31d353946437b6e069546176267e"}

[commit-bot: I haz the power, 2016-12-06 00:46:07]

Committed patchset #5 (id:80001)

[Alexander Alekseev, 2016-12-06 00:47:24]

On 2016/12/05 11:07:19, nhiroki wrote:
> On 2016/12/02 12:18:29, Alexander Alekseev wrote:
> > Hiroki, PTAL.
> > 
> > I put back all #ifdef DCHECK_IS_ON() because of Windows trybot. It looks
like
> a
> > race condition, or something that I cannot debug (I don't have Windows
machine
> > to test that).
> > 
> > What do you think?
> 
> I ran your PatchSet-3 on trybots and apparently it's working well:
> https://codereview.chromium.org/2549063002/
> 
> Could you try to land it again?

Yes, it worked. Thank you!

[commit-bot: I haz the power, 2016-12-06 00:49:38]

Description was changed from

==========
WebKit: remove DCHECK_IS_ON from FileWriterSync.

This CL removes checks for DCHECK_IS_ON in FileWriterSync as they are not used.
(DCHECK macro requires its arguments to be buildable even if check itself is
disabled.) So this CL fixes build in case we want debug build with DCHECKs
disabled.

R=nhiroki@chromium.org

BUG=666660
==========

to

==========
WebKit: remove DCHECK_IS_ON from FileWriterSync.

This CL removes checks for DCHECK_IS_ON in FileWriterSync as they are not used.
(DCHECK macro requires its arguments to be buildable even if check itself is
disabled.) So this CL fixes build in case we want debug build with DCHECKs
disabled.

R=nhiroki@chromium.org

BUG=666660

Committed: https://crrev.com/c9600cd059f7aa0231a89fa2817c4ffca0454122
Cr-Commit-Position: refs/heads/master@{#436473}
==========

[commit-bot: I haz the power, 2016-12-06 00:49:39]

Patchset 5 (id:??) landed as
https://crrev.com/c9600cd059f7aa0231a89fa2817c4ffca0454122
Cr-Commit-Position: refs/heads/master@{#436473}