Issue 2524773002: Update the bookmark tooltip text only when necessary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2524773002: Update the bookmark tooltip text only when necessary (Closed)

Created:
4 years ago by oshima

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews, tfarina

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

Update the bookmark tooltip text only when necessary BUG=612682 TEST=manual. see bug for repro step. Committed: https://chromium.googlesource.com/chromium/src/+/6a4d6d8670c5b9da20f522f21eabfdf0c62dd803

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -16 lines)			Patch
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.h	View	2 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc	View	2 chunks	+25 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

oshima

4 years ago (2016-11-22 15:48:01 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6a4d6d8670c5b9da20f522f21eabfdf0c62dd803.