Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2524753002: Add ossfuzz.c fuzzer for sqlite3 (taken from the upstream). (Closed)

Created:
4 years, 1 month ago by mmoroz
Modified:
4 years ago
CC:
chromium-reviews, fuzzing_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ossfuzz.c fuzzer for sqlite3 (taken from the upstream). R=aizatsky@chromium.org, inferno@chromium.org, ochang@chromium.org, shess@chromium.org BUG=665382 Committed: https://crrev.com/656b55356751d12fd8c643f927691275ef10dded Cr-Commit-Position: refs/heads/master@{#434002}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+375 lines, -0 lines) Patch
M third_party/sqlite/BUILD.gn View 1 chunk +11 lines, -0 lines 2 comments Download
A third_party/sqlite/fuzz/ossfuzz.c View 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/sqlite/fuzz/sql.dict View 1 chunk +282 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
mmoroz
4 years, 1 month ago (2016-11-22 12:36:20 UTC) #1
inferno
lgtm
4 years, 1 month ago (2016-11-22 15:15:29 UTC) #2
Scott Hess - ex-Googler
lgtm https://codereview.chromium.org/2524753002/diff/1/third_party/sqlite/BUILD.gn File third_party/sqlite/BUILD.gn (right): https://codereview.chromium.org/2524753002/diff/1/third_party/sqlite/BUILD.gn#newcode281 third_party/sqlite/BUILD.gn:281: # TODO(mmoroz, shess): remove fuzz/ossfuzz.c after next sqlite3 ...
4 years, 1 month ago (2016-11-22 19:14:15 UTC) #3
mmoroz
https://codereview.chromium.org/2524753002/diff/1/third_party/sqlite/BUILD.gn File third_party/sqlite/BUILD.gn (right): https://codereview.chromium.org/2524753002/diff/1/third_party/sqlite/BUILD.gn#newcode281 third_party/sqlite/BUILD.gn:281: # TODO(mmoroz, shess): remove fuzz/ossfuzz.c after next sqlite3 update. ...
4 years, 1 month ago (2016-11-22 20:11:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524753002/1
4 years, 1 month ago (2016-11-22 20:12:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 22:05:19 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/656b55356751d12fd8c643f927691275ef10dded Cr-Commit-Position: refs/heads/master@{#434002}
4 years, 1 month ago (2016-11-22 22:06:55 UTC) #10
aizatsky
Max, I have found that corpus improves coverage of this fuzzer a lot: https://github.com/google/oss-fuzz/blob/master/targets/sqlite3/Dockerfile#L28
4 years, 1 month ago (2016-11-22 22:18:41 UTC) #11
mmoroz
4 years ago (2016-12-12 12:23:40 UTC) #12
Message was sent while issue was closed.
On 2016/11/22 22:18:41, aizatsky wrote:
> Max,
> 
> I have found that corpus improves coverage of this fuzzer a lot:
> 
> https://github.com/google/oss-fuzz/blob/master/targets/sqlite3/Dockerfile#L28

Thanks for the notice, Mike! I've did the same and uploaded 1994 '*.test' files
from Chromium sqlite revision to
gs://clusterfuzz-corpus/libfuzzer/sqlite3_ossfuzz_fuzzer_static bucket.

Powered by Google App Engine
This is Rietveld 408576698