Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2524733007: [gc] Add runtime timer for gc prologue and epilogue callbacks (Closed)

Created:
4 years ago by Camillo Bruni
Modified:
4 years ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gc] Add runtime timer for gc prologue and epilogue callbacks BUG= Committed: https://crrev.com/c3e0ef8b003e43c9fcb1d21d01f505dcb46bc495 Cr-Commit-Position: refs/heads/master@{#41233}

Patch Set 1 #

Patch Set 2 : adding more gc counters #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/counters.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 4 chunks +4 lines, -0 lines 1 comment Download

Messages

Total messages: 17 (10 generated)
Camillo Bruni
PTAL
4 years ago (2016-11-23 09:16:17 UTC) #2
Michael Lippautz
lgtm
4 years ago (2016-11-23 12:23:59 UTC) #7
Hannes Payer (out of office)
https://codereview.chromium.org/2524733007/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/2524733007/diff/20001/src/heap/heap.cc#newcode858 src/heap/heap.cc:858: RuntimeCallTimerScope(isolate(), &RuntimeCallStats::GC_AllAvailableGarbage); Not sure what your naming scheme is ...
4 years ago (2016-11-23 16:53:05 UTC) #9
Hannes Payer (out of office)
LGTM btw
4 years ago (2016-11-23 16:58:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524733007/20001
4 years ago (2016-11-23 17:27:26 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-23 18:00:09 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-23 18:00:26 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c3e0ef8b003e43c9fcb1d21d01f505dcb46bc495
Cr-Commit-Position: refs/heads/master@{#41233}

Powered by Google App Engine
This is Rietveld 408576698