Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2524733004: Avoid random stacktraces being printed from tools/test.py during test runs (Closed)

Created:
4 years, 1 month ago by kustermann
Modified:
4 years ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, Florian Schneider, Cutch, Vyacheslav Egorov (Google)
Visibility:
Public.

Description

Avoid random stacktraces being printed from tools/test.py during test runs Previously the testing script was just printing interleaved stack traces with all the other output. Which means it's not associatable with a single test and is highly confusing! This CL associates the stack trace information of tests which time out to the particular test which timed out. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/b1c04f0538f68f9a9a59953e80adae4d015c58cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -30 lines) Patch
M tools/testing/dart/test_runner.dart View 3 chunks +21 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
4 years, 1 month ago (2016-11-22 15:11:38 UTC) #2
Bill Hesse
LGTM. Much better.
4 years, 1 month ago (2016-11-22 15:18:04 UTC) #3
kustermann
4 years ago (2016-11-23 07:39:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b1c04f0538f68f9a9a59953e80adae4d015c58cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698