Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2524733003: Rename 'interface' parameter (Closed)

Created:
4 years, 1 month ago by Tomasz Moniuszko
Modified:
4 years ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename 'interface' parameter It conflicts with define from combaseapi.h from Windows SDK. BUG= Committed: https://crrev.com/54cb4c96985f6e139d0615b8341d3d79fbaf8cf1 Cr-Commit-Position: refs/heads/master@{#435169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/power_usage_monitor/power_usage_monitor.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/power_usage_monitor/power_usage_monitor.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Tomasz Moniuszko
4 years, 1 month ago (2016-11-22 13:38:12 UTC) #2
Tomasz Moniuszko
On 2016/11/22 13:38:12, Tomasz Moniuszko wrote: thakis@, will you accept this simple fix? combaseapi.h defines ...
4 years ago (2016-11-29 09:49:26 UTC) #3
Nico
lgtm Sorry, this arrived around the long weekend and I missed it.
4 years ago (2016-11-29 16:21:16 UTC) #4
Tomasz Moniuszko
On 2016/11/29 16:21:16, Nico wrote: > lgtm > > Sorry, this arrived around the long ...
4 years ago (2016-11-30 07:47:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524733003/1
4 years ago (2016-11-30 07:48:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 08:30:04 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-30 08:34:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54cb4c96985f6e139d0615b8341d3d79fbaf8cf1
Cr-Commit-Position: refs/heads/master@{#435169}

Powered by Google App Engine
This is Rietveld 408576698