Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: components/arc/kiosk/arc_kiosk_bridge.h

Issue 2524673003: arc: Stop/start ARC++ kiosk app when maintenance session started/finished. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Pass BrowserContext from ArcServiceManager. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/kiosk/arc_kiosk_bridge.h
diff --git a/components/arc/kiosk/arc_kiosk_bridge.h b/components/arc/kiosk/arc_kiosk_bridge.h
index ab0323f971a9259c894a5d532093d9f0896a0a11..d468bef7807e2ec48a7a7eb9a7c50f27eef864b3 100644
--- a/components/arc/kiosk/arc_kiosk_bridge.h
+++ b/components/arc/kiosk/arc_kiosk_bridge.h
@@ -11,8 +11,11 @@
#include "components/arc/arc_service.h"
#include "components/arc/common/kiosk.mojom.h"
#include "components/arc/instance_holder.h"
+#include "content/public/browser/browser_context.h"
Luis Héctor Chávez 2016/11/23 17:42:09 Same here, drop and forward-declare BrowserContext
Sergey Poromov 2016/11/23 18:05:56 Done.
#include "mojo/public/cpp/bindings/binding.h"
+using content::BrowserContext;
Luis Héctor Chávez 2016/11/23 17:42:09 Avoid global "using" in .h files at all costs.
Sergey Poromov 2016/11/23 18:05:57 Done.
+
namespace arc {
class ArcBridgeService;
@@ -21,7 +24,8 @@ class ArcKioskBridge : public ArcService,
public InstanceHolder<mojom::KioskInstance>::Observer,
public mojom::KioskHost {
public:
- explicit ArcKioskBridge(ArcBridgeService* bridge_service);
+ explicit ArcKioskBridge(ArcBridgeService* bridge_service,
+ BrowserContext* browser_context);
~ArcKioskBridge() override;
// InstanceHolder<mojom::KioskInstance>::Observer overrides.
@@ -34,6 +38,8 @@ class ArcKioskBridge : public ArcService,
private:
mojo::Binding<mojom::KioskHost> binding_;
+ BrowserContext* browser_context_;
Luis Héctor Chávez 2016/11/23 17:42:09 nit: content::BrowserContext* const browser_contex
Sergey Poromov 2016/11/23 18:05:57 Done.
+
DISALLOW_COPY_AND_ASSIGN(ArcKioskBridge);
};

Powered by Google App Engine
This is Rietveld 408576698