components/arc/kiosk/DEPS - Issue 2524673003: arc: Stop/start ARC++ kiosk app when maintenance session started/finished.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/arc/kiosk/DEPS

Issue 2524673003: arc: Stop/start ARC++ kiosk app when maintenance session started/finished. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix includes and usages. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 document.getElementById("p4").innerHTML = "PASS";	1 include_rules = [

	2 "+chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.h",
	Luis Héctor Chávez 2016/11/30 19:11:54 oh, I'm terribly sorry about this, I should have b oh, I'm terribly sorry about this, I should have been moer explicit: Code under components/ is not allowed to depend on chrome/, because it would create a dependency cycle. In order to break the cycle one thing you can do is introduce class Delegate { public: virtual ~Delegate() = default; virtual void MaintenanceSessionCreated() = 0; virtual void MaintenanceSessionFinished() = 0; } in the ArcKioskBridge, and that delegate to the constructor of ArcKioskBridge. You can make ArcKioskAppService implement that Delegate. You can then remove the code from ArcAppListPrefs that creates (and holds) the reference to ArcKioskAppService, and instead have the ArcServiceLauncher create the ArcKioskBridge with the same condition it has right now: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/arc/arc_app_l... Sergey Poromov 2016/12/01 19:04:59 Done. Show quoted text On 2016/11/30 19:11:54, Luis Héctor Chávez wrote: > oh, I'm terribly sorry about this, I should have been moer explicit: > > Code under components/ is not allowed to depend on chrome/, because it would > create a dependency cycle. In order to break the cycle one thing you can do is > introduce > > class Delegate { > public: > virtual ~Delegate() = default; > virtual void MaintenanceSessionCreated() = 0; > virtual void MaintenanceSessionFinished() = 0; > } > > in the ArcKioskBridge, and that delegate to the constructor of ArcKioskBridge. > You can make ArcKioskAppService implement that Delegate. You can then remove the > code from ArcAppListPrefs that creates (and holds) the reference to > ArcKioskAppService, and instead have the ArcServiceLauncher create the > ArcKioskBridge with the same condition it has right now: > https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/arc/arc_app_l... Done.
	3 ]

OLD	NEW