Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 2524653002: Replace ASSERT with DCHECK in wtf/Threading* (Closed)

Created:
4 years, 1 month ago by Charlie Harrison
Modified:
4 years, 1 month ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT with DCHECK in wtf/Threading* BUG=596760 Committed: https://crrev.com/65157fe7b75097e92a381363b6ef49291d538593 Cr-Commit-Position: refs/heads/master@{#433848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M third_party/WebKit/Source/wtf/Threading.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ThreadingPthreads.cpp View 10 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/wtf/ThreadingWin.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Charlie Harrison
tkent ptal?
4 years, 1 month ago (2016-11-22 12:56:34 UTC) #6
tkent
lgtm
4 years, 1 month ago (2016-11-22 13:04:23 UTC) #7
Charlie Harrison
Thanks, this'll make the changes to SchemeRegistry more palatable.
4 years, 1 month ago (2016-11-22 13:52:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524653002/1
4 years, 1 month ago (2016-11-22 13:52:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 13:56:32 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 13:58:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65157fe7b75097e92a381363b6ef49291d538593
Cr-Commit-Position: refs/heads/master@{#433848}

Powered by Google App Engine
This is Rietveld 408576698