appengine/findit/waterfall/send_notification_for_culprit_pipeline.py - Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/send_notification_for_culprit_pipeline.py

Issue 2524633002: [Culprit-Finder] Refactor GitilesRepostory to make http_client required argument. (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/waterfall/send_notification_for_culprit_pipeline.py

diff --git a/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py b/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py

index 1ce12ee9853c23d7c344886022f536228f6f5ece..b81365c260b3462329efb369ff162e8117176c14 100644

--- a/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py

+++ b/appengine/findit/waterfall/send_notification_for_culprit_pipeline.py

@@ -93,7 +93,7 @@ def _GetCulpritInfo(repo_name, revision):

# TODO(stgao): get repo url at runtime based on the given repo name.

# unused arg - pylint: disable=W0612,W0613

repo = GitilesRepository(

- 'https://chromium.googlesource.com/chromium/src.git', HttpClient())

+ HttpClient(), 'https://chromium.googlesource.com/chromium/src.git')

change_log = repo.GetChangeLog(revision)

return change_log.commit_position, change_log.code_review_url

« no previous file with comments | « appengine/findit/waterfall/pull_changelog_pipeline.py ('k') | no next file » | no next file with comments »