[Culprit-Finder] Refactor GitilesRepostory to make http_client required argument.

appengine/findit/waterfall/build_failure_analysis.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import os
 import re
 
 from common.http_client_appengine import HttpClientAppengine as HttpClient
 from lib.gitiles.diff import ChangeType
@@ skipping 26 matching lines @@
 
 def _GetGitBlame(repo_info, touched_file_path):
   """Gets git blames of touched_file.
 
   Args:
     repo_info (dict): The repo_url and revision for the build cycle.
     touched_file_path (str): Full path of a file in change_log.
   """
   if repo_info:
     repo_url = repo_info['repo_url']
-    git_repo = GitilesRepository(repo_url, HttpClient())
+    git_repo = GitilesRepository(HttpClient(), repo_url)
     revision = repo_info['revision']
     return git_repo.GetBlame(touched_file_path, revision)
 
 
 def _GetChangedLinesForChromiumRepo(repo_info, touched_file, line_numbers,
                                     suspected_revision):
   """Checks if the CL made change close to the failed line in log.
 
   Args:
     repo_info (dict): The repo_url and revision for the build cycle.
@@ skipping 377 matching lines @@
 
   return None, None
 
 
 def _GetChangedLinesForDependencyRepo(roll, file_path_in_log, line_numbers):
   """Gets changed line numbers for file in failure log.
 
     Tests if the same lines mentioned in failure log are changed within
     the DEPS roll, if so, return those line numbers.
   """
-  roll_repo = GitilesRepository(roll['repo_url'], HttpClient())
+  roll_repo = GitilesRepository(HttpClient(), roll['repo_url'])
   old_revision = roll['old_revision']
   new_revision = roll['new_revision']
   old_change_log = roll_repo.GetChangeLog(old_revision)
   old_rev_author_time = old_change_log.author_time
   new_change_log = roll_repo.GetChangeLog(new_revision)
   new_rev_author_time = new_change_log.author_time
 
   file_change_type = None
   changed_line_numbers = []
 
@@ skipping 343 matching lines @@
             _SaveFailureToMap(
                 cl_failure_map, new_suspected_cl_dict, step_name, None,
                 max(justification_dict['hints'].values()))
 
     # TODO(stgao): sort CLs by score.
     analysis_result['failures'].append(step_analysis_result)
 
   suspected_cls = _ConvertCLFailureMapToList(cl_failure_map)
 
   return analysis_result, suspected_cls