Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2524613004: [Merge M-56] Return cached query result for canMakeActivePayment. (Closed)

Created:
4 years, 1 month ago by please use gerrit instead
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge M-56] Return cached query result for canMakeActivePayment. The PaymentRequest.canMakeActivePayment() feature, which is currently hidden behind a flag, throttles queries of supported methods to reduce the risk of user fingerprinting. Since the upcoming (not yet implemented) 'basic-card' method can be used with different subsets of card networks ('visa', 'mastercard', etc.) and types ('credit', 'debit', 'prepaid'), this patch changes canMakeActivePayment() to return last cached result instead of re-querying every time. This also happens to be more inline with the proposed specification language: "Multiple calls to canMakeActivePayment will result in cached response from previous call." Proposed PaymentRequest.canMakeActivePayment() specification: https://github.com/w3c/browser-payment-api/pull/316/files BUG=662931 Review-Url: https://codereview.chromium.org/2507063009 Cr-Commit-Position: refs/heads/master@{#433689} (cherry picked from commit 639ffbbca80f848266bb78f5ce28f0eddc7649fd) Committed: https://chromium.googlesource.com/chromium/src/+/9296d6865e182c85bac474630f7cb09b07c2b346

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
please use gerrit instead
4 years, 1 month ago (2016-11-22 14:52:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9296d6865e182c85bac474630f7cb09b07c2b346.

Powered by Google App Engine
This is Rietveld 408576698