Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2524613003: Fix an issue for blimp_support_strings.grd translation. (Closed)

Created:
4 years, 1 month ago by xingliu
Modified:
4 years, 1 month ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix an issue for blimp_support_strings.grd translation. The translation script needs the prefix of xtb files to be the same as the grd files. This CL changed the translation file declaration in the grd file and renamed all the xtb files to have the same prefix as the grd file. BUG=665084 Committed: https://crrev.com/3e9d98ff9249bf9d16fecda9af4ce33cc841819d Cr-Commit-Position: refs/heads/master@{#433918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -344 lines) Patch
M blimp/client/support/resources/blimp_support_strings.grd View 1 chunk +43 lines, -43 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_am.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_ar.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_bg.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_ca.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_cs.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_da.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_de.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_el.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_en-GB.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_es.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_es-419.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_fa.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_fi.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_fil.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_fr.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_hi.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_hr.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_hu.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_id.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_it.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_iw.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_ja.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_ko.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_lt.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_lv.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_nl.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_no.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_pl.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_pt-BR.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_pt-PT.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_ro.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_ru.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_sk.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_sl.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_sr.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_sv.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_sw.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_th.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_tr.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_uk.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_vi.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_zh-CN.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
D blimp/client/support/resources/translations/blimp_strings_zh-TW.xtb View 1 chunk +0 lines, -8 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_am.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_ar.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_bg.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_ca.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_cs.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_da.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_de.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_el.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_en-GB.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_es.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_es-419.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_fa.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_fi.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_fil.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_fr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_hi.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_hr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_hu.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_id.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_it.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_iw.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_ja.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_ko.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_lt.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_lv.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_nl.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_no.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_pl.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_pt-BR.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_pt-PT.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_ro.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_ru.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_sk.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_sl.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_sr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_sv.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_sw.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_th.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_tr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_uk.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_vi.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_zh-CN.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/support/resources/translations/blimp_support_strings_zh-TW.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
xingliu
Fix an issue for the translation script, that xtb file prefix should be the same ...
4 years, 1 month ago (2016-11-22 02:39:31 UTC) #4
David Trainor- moved to gerrit
lgtm
4 years, 1 month ago (2016-11-22 17:57:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524613003/1
4 years, 1 month ago (2016-11-22 18:15:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 18:22:08 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 18:24:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e9d98ff9249bf9d16fecda9af4ce33cc841819d
Cr-Commit-Position: refs/heads/master@{#433918}

Powered by Google App Engine
This is Rietveld 408576698