Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2524583002: DevTools: Sources: Remove unused properties on CMTE (Closed)

Created:
4 years, 1 month ago by einbinder
Modified:
4 years ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Sources: Remove unused properties on CMTE _nestedUpdatesCounter and _fixWordMovement were unused, and FixWordMovement makes more sense as a static method. BUG=none Committed: https://crrev.com/b74484ef3fa0921d04968cc03dc83f8c389f6106 Cr-Commit-Position: refs/heads/master@{#435697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -54 lines) Patch
M third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js View 4 chunks +49 lines, -54 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
einbinder
ptal
4 years ago (2016-11-30 21:25:06 UTC) #3
lushnikov
lgtm
4 years ago (2016-11-30 21:44:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524583002/1
4 years ago (2016-12-01 20:07:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 20:20:57 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-01 20:26:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b74484ef3fa0921d04968cc03dc83f8c389f6106
Cr-Commit-Position: refs/heads/master@{#435697}

Powered by Google App Engine
This is Rietveld 408576698