Chromium Code Reviews Chromium Code Reviews
Issue 2524533002:
Added UMA for usage of BudgetAPI calls. (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 9bc93150da2a4b1e2722d224bde95790dda6ec31..f32115d14a7aae03f2af6310b08925c81797fe96 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -49821,6 +49821,25 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="PushMessaging.BudgetAPIQuery"> |
|
Peter Beverloo
2016/11/28 10:59:01
needs an @units attribute (<histogram name=".." un
Peter Beverloo
2016/11/28 10:59:01
Why is this in the PushMessaging namespace? It's a
harkness
2016/11/28 13:58:04
Since I'm leaving it as recording budget, I change
harkness
2016/11/28 13:58:04
As discussed in chat, I had originally chosen the
|
| + <owner>harkness@chromium.org</owner> |
| + <summary> |
| + Whenever the Budget API framework receives a query for the current budget, |
| + this records the total budget available to the origin, which is an internal |
| + Chrome value for the amount of background processing an origin can do |
| + without visibly alerting the user. Scale for the budget is 0 to 100. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="PushMessaging.BudgetAPIReserve"> |
|
Peter Beverloo
2016/11/28 10:59:01
dito on both counts (no pun intended)
harkness
2016/11/28 13:58:04
Fixed the namespace, instead of units, I made the
|
| + <owner>harkness@chromium.org</owner> |
| + <summary> |
| + Whenever the Budget API framework receives a request to reserve budget for a |
| + future background operation, this records whether the reserve request |
| + succeeded or not. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="PushMessaging.DeliveryStatus" enum="PushDeliveryStatus"> |
| <owner>johnme@google.com</owner> |
| <summary> |
