Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 2524523002: Remove various 'using std::' statements from QUIC code and use (Closed)

Created:
4 years, 1 month ago by Ryan Hamilton
Modified:
4 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove various 'using std::' statements from QUIC code and use std:: prefixes instead. BUG= Committed: https://crrev.com/872e00e4be2d1bce4ad34224ae4dd5e8b9717f61 Cr-Commit-Position: refs/heads/master@{#435832}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -318 lines) Patch
M net/quic/chromium/crypto/proof_source_chromium.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/chromium/crypto/proof_test_chromium.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M net/quic/chromium/crypto/proof_verifier_chromium.cc View 6 chunks +5 lines, -6 lines 0 comments Download
M net/quic/chromium/crypto_test_utils_chromium.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 1 10 chunks +12 lines, -12 lines 0 comments Download
M net/quic/chromium/quic_utils_chromium_test.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/core/congestion_control/cubic.cc View 1 3 chunks +4 lines, -6 lines 0 comments Download
M net/quic/core/congestion_control/cubic_bytes.cc View 1 3 chunks +4 lines, -6 lines 0 comments Download
M net/quic/core/congestion_control/general_loss_algorithm_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/congestion_control/hybrid_slow_start.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M net/quic/core/congestion_control/pacing_sender.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M net/quic/core/congestion_control/rtt_stats.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_base.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_bytes.cc View 1 4 chunks +8 lines, -10 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_packets.cc View 1 4 chunks +7 lines, -8 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/crypto_handshake_message.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/crypto_secret_boxer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_server_test.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config_test.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/core/crypto/strike_register_test.cc View 2 chunks +1 line, -4 lines 0 comments Download
M net/quic/core/frames/quic_ack_frame.cc View 1 3 chunks +2 lines, -4 lines 0 comments Download
M net/quic/core/frames/quic_blocked_frame.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/core/frames/quic_connection_close_frame.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M net/quic/core/frames/quic_frame.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/frames/quic_goaway_frame.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/frames/quic_padding_frame.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/frames/quic_path_close_frame.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/core/frames/quic_rst_stream_frame.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/core/frames/quic_stop_waiting_frame.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/core/frames/quic_stream_frame.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/frames/quic_window_update_frame.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M net/quic/core/interval_set.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/interval_set_test.cc View 6 chunks +7 lines, -10 lines 0 comments Download
M net/quic/core/interval_test.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/quic/core/quic_config.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/quic_connection.cc View 1 4 chunks +6 lines, -13 lines 0 comments Download
M net/quic/core/quic_connection_stats.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_frame_list.cc View 8 chunks +7 lines, -8 lines 0 comments Download
M net/quic/core/quic_framer.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 1 4 chunks +3 lines, -4 lines 0 comments Download
M net/quic/core/quic_multipath_sent_packet_manager.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/core/quic_packet_creator.cc View 1 7 chunks +7 lines, -11 lines 0 comments Download
M net/quic/core/quic_packet_creator_test.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_packets.cc View 1 4 chunks +3 lines, -6 lines 0 comments Download
M net/quic/core/quic_received_packet_manager.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M net/quic/core/quic_received_packet_manager_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager.cc View 1 7 chunks +18 lines, -21 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager_test.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_session.cc View 1 2 chunks +5 lines, -7 lines 0 comments Download
M net/quic/core/quic_spdy_stream.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_spdy_stream_test.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/quic_stream.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/core/quic_stream_sequencer.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer_test.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_test.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_types.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/quic/core/quic_unacked_packet_map.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_unacked_packet_map_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/core/quic_versions.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/core/spdy_utils.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_factory_peer.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/test_tools/quic_stream_sequencer_peer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 1 5 chunks +4 lines, -5 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 3 chunks +4 lines, -6 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_http_response_cache_test.cc View 1 5 chunks +6 lines, -5 lines 0 comments Download
M net/tools/quic/quic_simple_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_client_bin.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/stateless_rejector_test.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Ryan Hamilton
4 years, 1 month ago (2016-11-21 22:35:27 UTC) #2
Victor Vasiliev
LGTM provided that this compiles.
4 years, 1 month ago (2016-11-21 22:48:32 UTC) #3
Ryan Hamilton
zhongyi: PTAL. Victor has LGTM'd but is not a committer.
4 years ago (2016-12-01 23:53:01 UTC) #10
Zhongyi Shi
lgtm
4 years ago (2016-12-01 23:59:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524523002/40001
4 years ago (2016-12-02 00:37:32 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years ago (2016-12-02 02:48:50 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-02 02:50:37 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/872e00e4be2d1bce4ad34224ae4dd5e8b9717f61
Cr-Commit-Position: refs/heads/master@{#435832}

Powered by Google App Engine
This is Rietveld 408576698