Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2524503002: chrome/android/intel/clang: Use --icf=safe instead of --icf=all. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index c4d61e2281a7662b4a3ca17b8fe92dac7d15469b..08585b8539a3159819212a46802edd707fe586e7 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -372,10 +372,13 @@ config("compiler") {
# Additionally, on cast Android x86, --icf=all causes issues.
if (is_android && current_cpu == "x86") {
ldflags += [ "-Wl,--icf=none" ]
- } else if (is_clang || is_chromeos ||
+ } else if ((is_clang && !is_android) || is_chromeos ||
(current_cpu != "x86" && current_cpu != "x64")) {
+ # TODO(thakis): Remove `!is_android` above once our gold has been rolled
+ # with the fix for https://sourceware.org/bugzilla/show_bug.cgi?id=17704
+ # merged. See also https://crbug.com/663886
ldflags += [ "-Wl,--icf=all" ]
- } else if (!is_android) {
+ } else if (!is_android || is_clang) {
ldflags += [ "-Wl,--icf=safe" ]
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698