Issue 2524463005: Add tests for the real generic method syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2524463005: Add tests for the real generic method syntax (Closed)

Created:
4 years, 1 month ago by Brian Wilkerson

Modified:
4 years, 1 month ago

Reviewers:
vsm, Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add tests for the real generic method syntax R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/89cab97dd8a1612b035bbc4cd7d6d9cd61fc487a

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+782 lines, -7 lines)			Patch
	M	pkg/analyzer/test/src/task/strong/inferred_type_test.dart	View		40 chunks	+782 lines, -7 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

Committed patchset #1 (id:1) manually as 89cab97dd8a1612b035bbc4cd7d6d9cd61fc487a (presubmit successful).

4 years, 1 month ago (2016-11-22 20:23:31 UTC) #5

Paul Berry

4 years, 1 month ago (2016-11-22 20:41:46 UTC) #7

Message was sent while issue was closed.

This caused some resynthesis tests in resynthesize_ast_test.dart to start
failing.  It looks like overrides of some of the new tests need to be added to
AstInferredTypeTest with the "@failingTest" annotation.

Would you mind having a look?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages