Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2524463003: Disable under-invalidation checking in two video paint invalidation tests (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
chrishtr
CC:
blink-reviews, chromium-reviews, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable under-invalidation checking in two video paint invalidation tests Because of lacking of real-time notification of buffered ranges, we allow short period of under-invalidation of buffered ranges for good perfomance and code simplicity. See crbug.com/484288. Disable under-invalidation checking for the two tests which don't play the video and encountered under-invalidation. BUG=667404 Committed: https://crrev.com/b3184e441e689e84c4aa367e9ac514c22bdb6145 Cr-Commit-Position: refs/heads/master@{#433736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/paint/invalidation/video-mute-repaint.html View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/video-unmute-repaint.html View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Xianzhu
4 years, 1 month ago (2016-11-21 21:53:58 UTC) #3
chrishtr
lgtm
4 years, 1 month ago (2016-11-21 21:58:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2524463003/1
4 years, 1 month ago (2016-11-21 21:58:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 01:50:21 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 01:53:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3184e441e689e84c4aa367e9ac514c22bdb6145
Cr-Commit-Position: refs/heads/master@{#433736}

Powered by Google App Engine
This is Rietveld 408576698