Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: pkg/analysis_server/lib/src/domain_completion.dart

Issue 2524453002: Issue 27856. Fix for reponding to execution domain requests. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/domain_completion.dart
diff --git a/pkg/analysis_server/lib/src/domain_completion.dart b/pkg/analysis_server/lib/src/domain_completion.dart
index c0df56e96294b4e1a304e1b9fdc1d504894ce206..6bad4431a2ab122d8773b9cdd4259df474e243cb 100644
--- a/pkg/analysis_server/lib/src/domain_completion.dart
+++ b/pkg/analysis_server/lib/src/domain_completion.dart
@@ -107,14 +107,11 @@ class CompletionDomainHandler implements RequestHandler {
if (server.searchEngine == null) {
return new Response.noIndexGenerated(request);
}
- runZoned(() {
- try {
- String requestName = request.method;
- if (requestName == COMPLETION_GET_SUGGESTIONS) {
- processRequest(request);
- }
- } on RequestFailure catch (exception) {
- return exception.response;
+ return runZoned(() {
+ String requestName = request.method;
+ if (requestName == COMPLETION_GET_SUGGESTIONS) {
+ processRequest(request);
+ return Response.DELAYED_RESPONSE;
}
return null;
}, onError: (exception, stackTrace) {
@@ -123,7 +120,6 @@ class CompletionDomainHandler implements RequestHandler {
exception,
stackTrace);
});
- return Response.DELAYED_RESPONSE;
}
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698